From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] fs/ext4-new-features: add ext4-new-features tests to the default
Date: Thu, 14 Nov 2013 13:34:25 +0100 [thread overview]
Message-ID: <20131114123425.GC13348@rei> (raw)
In-Reply-To: <20131113160220.GA28712@rei>
Hi!
> > include $(top_srcdir)/include/mk/generic_trunk_target.mk
> > diff --git a/testcases/kernel/fs/ext4-new-features/Makefile b/testcases/kernel/fs/ext4-new-features/Makefile
> > index 208b8a6..1ad1c3c 100644
> > --- a/testcases/kernel/fs/ext4-new-features/Makefile
> > +++ b/testcases/kernel/fs/ext4-new-features/Makefile
> > @@ -32,6 +32,7 @@ FILTER_OUT_DIRS := $(FFSBDIR)
> > FFSB := $(FFSBDIR)/ffsb
> >
> > $(FFSB): $(FFSBDIR)
> > + cd $^; ./configure
> > $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" all
> > cp $(FFSBDIR)/ffsb ffsb
>
> The way how ffsb is bundled in LTP is simply wrong, it shouldn't be in
> the source tree at all. What I would like to see is to:
>
> 1. modify testcases that depends on it to return TCONF with
> message that explains that ffsb must be installed to run
> the testcases if ffsb is not found in PATH
>
> or alternatively use something different to create the
> I/O load
>
> 2. remove ffsb from the LTP git tree
Or at least the source tree should be moved to a proper place, there is
utils/benchmar/ directory for this purpose allready.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-11-14 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 12:57 [LTP] [PATCH] fs/ext4-new-features: add ext4-new-features tests to the default Xiaoguang Wang
2013-11-13 16:02 ` chrubis
2013-11-14 12:34 ` chrubis [this message]
[not found] ` <52858E29.7090602@cn.fujitsu.com>
2013-11-19 14:22 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114123425.GC13348@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox