Re: [LTP] safe_touch and utimensat

[chrubis@suse.cz]

Hi!
> Some distributions (RHEL5, for instance) don't have defined utimensat()
> system call. So I introduced an autoconf check for this, otherwise safe_file_ops.c can 
> not be compiled on these distributions.
> 
> Actually, I'm not satisfied with
>     utimes(pathname, NULL)
> because it throws away the time-changing logic from safe_touch().
> 
> How do you think it is safe to explicitly define UTIME_* constants in LTP
> sources (safe_file_ops.h):
> 
> #ifndef UTIME_NOW
> #define UTIME_NOW ((1l << 30) - 1l)
> #endif
> 
> #ifndef UTIME_OMIT
> #define UTIME_OMIT     ((1l << 30) - 2l)
> #endif

That shouldn't be a problem. These constants are part of ABI they will
not change in future.

Actually LTP has several places where such defines are used in order not
to overcomplicate the autoconf checks.

But I would like to start sticking these into a specific directory under
include/. For example to put these two into include/lapi/utime.h and
include it from the safe_file_ops.h.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list