[LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message

public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed

* [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message
@ 2013-11-14  3:38 Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 2/8] ltp-networking/rpc: gave precise test name Vincent Hsu
                   ` (7 more replies)
  0 siblings, 8 replies; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/multicast/mc_cmds/mc_cmds        |    9 +++++++--
 testcases/network/multicast/mc_commo/mc_commo      |    8 ++++++--
 testcases/network/multicast/mc_member/mc_member    |    8 ++++++--
 testcases/network/multicast/mc_opts/mc_opts        |    8 ++++++--
 testcases/network/nfs/fsx-linux/fsx.sh             |    7 +++++--
 testcases/network/nfs/nfs01/nfs01                  |    7 +++++--
 testcases/network/nfs/nfs02/nfs02                  |    7 +++++--
 testcases/network/nfs/nfs03/nfs03                  |    7 +++++--
 testcases/network/nfs/nfslock01/nfslock01          |    7 +++++--
 testcases/network/nfs/nfsstat01/nfsstat01          |    7 +++++--
 testcases/network/nfs/nfsstress/nfsstress          |    7 +++++--
 testcases/network/rpc/basic_tests/rpc01/rpc01      |    7 +++++--
 .../network/rpc/basic_tests/rpcinfo/rpcinfo01      |    7 +++++--
 testcases/network/rpc/basic_tests/rup/rup01        |    7 +++++--
 testcases/network/rpc/basic_tests/rusers/rusers01  |    7 +++++--
 15 files changed, 80 insertions(+), 30 deletions(-)

diff --git a/testcases/network/multicast/mc_cmds/mc_cmds b/testcases/network/multicast/mc_cmds/mc_cmds
index d27f669..9c31844 100755
--- a/testcases/network/multicast/mc_cmds/mc_cmds
+++ b/testcases/network/multicast/mc_cmds/mc_cmds
@@ -36,6 +36,11 @@ $trace_logic

 TC=mc_cmds
 PING_OUT=/tmp/${TC}_out
+
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1
+
 # Set the LTPROOT variable to the correct path
 # from the ltp/testcases/bin directory or the
 # /ltp/testcases/network/multicast/mc_cmds directory
@@ -188,8 +193,8 @@ end_testcase()
    # Call other cleanup functions
    [ $CLEANUP = "ON" ] && do_cleanup

-   [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/multicast/mc_commo/mc_commo b/testcases/network/multicast/mc_commo/mc_commo
index 50fa6b9..14dce85 100755
--- a/testcases/network/multicast/mc_commo/mc_commo
+++ b/testcases/network/multicast/mc_commo/mc_commo
@@ -51,6 +51,10 @@ OUTFILE=$TCtmp/mc_commo_out
 NUMLOOPS=${NUMLOOPS:-2}
 INTERFACE=${INTERFACE:-$("$LTPROOT/bin/gethost" `hostname` | grep addresses: | awk '{print $2}')}

+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1
+
 this_file=${0##*/}
 trap "interrupt_test" 2

@@ -195,8 +199,8 @@ end_testcase()
    # Call other cleanup functions
    [ $CLEANUP = "ON" ] && do_cleanup

-   [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/multicast/mc_member/mc_member b/testcases/network/multicast/mc_member/mc_member
index 0e79cdb..6801ebf 100755
--- a/testcases/network/multicast/mc_member/mc_member
+++ b/testcases/network/multicast/mc_member/mc_member
@@ -50,6 +50,10 @@ GLIST=${GLIST:-$TCsrc/ManyGroups}
 TooManyGLIST=${TooManyGLIST:-$TCsrc/TooManyGroups}
 ERRFILE=${ERRFILE:-$TCtmp/errors}

+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1
+
 this_file=${0##*/}
 trap "interrupt_test" 2

@@ -183,8 +187,8 @@ end_testcase()
    # Call other cleanup functions
    [ $CLEANUP = "ON" ] && do_cleanup

-   [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/multicast/mc_opts/mc_opts b/testcases/network/multicast/mc_opts/mc_opts
index 41e1d68..a029f1e 100755
--- a/testcases/network/multicast/mc_opts/mc_opts
+++ b/testcases/network/multicast/mc_opts/mc_opts
@@ -49,6 +49,10 @@ EXECUTABLES=${EXECUTABLES:-"opts opts_e"}
 NUMLOOPS=${NUMLOOPS:-10}
 IPADDR=${IPADDR:-$("$LTPROOT/bin/gethost" `hostname`| grep address |awk '{ print $2 }')}

+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1
+
 this_file=${0##*/}
 trap "interrupt_test" 2

@@ -138,8 +142,8 @@ end_testcase()
    # Call other cleanup functions
    [ $CLEANUP = "ON" ] && do_cleanup

-   [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/nfs/fsx-linux/fsx.sh b/testcases/network/nfs/fsx-linux/fsx.sh
index 9d94166..fddaf03 100755
--- a/testcases/network/nfs/fsx-linux/fsx.sh
+++ b/testcases/network/nfs/fsx-linux/fsx.sh
@@ -51,6 +51,9 @@ TCdat=${TCdat:=$TCbin}
 TCsrc=${TCsrc:=$TCbin}
 TCtmp=${TCtmp:=$TCbin/$TC$$}
 TCdump=${TCdump:=$TCbin}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 # If CLEANUP is not set; set it to "ON"
 CLEANUP=${CLEANUP:="ON"}
@@ -177,8 +180,8 @@ $trace_logic
  rsh -n $RHOST "rm -rf $TESTDIR"
     fi

-    [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-    echo "Test Failed: $@"
+    [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+    tst_resm TFAIL "Test Failed: $@"
     exit 1
 }

diff --git a/testcases/network/nfs/nfs01/nfs01 b/testcases/network/nfs/nfs01/nfs01
index 924f2c2..1a942c4 100755
--- a/testcases/network/nfs/nfs01/nfs01
+++ b/testcases/network/nfs/nfs01/nfs01
@@ -48,6 +48,9 @@ TCdat=${TCdat:=$TCbin}
 TCsrc=${TCsrc:=$TCbin}
 TCtmp=${TCtmp:=$TCbin/$TC$$}
 TCdump=${TCdump:=$TCbin}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 # If CLEANUP is not set; set it to "ON"
 CLEANUP=${CLEANUP:="ON"}
@@ -187,8 +190,8 @@ $trace_logic
 		 rsh -n $RHOST "rm -rf $TESTDIR"
     fi

-    [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-    echo "Test Failed: $@"
+    [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+    tst_resm TFAIL "Test Failed: $@"
     exit 1
 }

diff --git a/testcases/network/nfs/nfs02/nfs02 b/testcases/network/nfs/nfs02/nfs02
index c655678..ab0e3c7 100755
--- a/testcases/network/nfs/nfs02/nfs02
+++ b/testcases/network/nfs/nfs02/nfs02
@@ -46,6 +46,9 @@ TCbin=${TCbin:=`pwd`}
 TCdat=${TCdat:=$TCbin/datafiles}
 TCsrc=${TCsrc:=$TCbin}
 TCtmp=${TCtmp:=$TCbin/$TC$$}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 PID=$$

@@ -221,8 +224,8 @@ $trace_logic
        do_cleanup
     fi

-    [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-    echo "Test Failed: $@"
+    [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+    tst_resm TFAIL "Test Failed: $@"
     exit 1
 }

diff --git a/testcases/network/nfs/nfs03/nfs03 b/testcases/network/nfs/nfs03/nfs03
index 80a4cbd..445c6ae 100755
--- a/testcases/network/nfs/nfs03/nfs03
+++ b/testcases/network/nfs/nfs03/nfs03
@@ -49,6 +49,9 @@ TCsrc=${TCsrc:=$TCbin}
 TCtmp=${TCtmp:=$TCbin/$TC$$}
 TCdump=${TCdump:=$TCbin}
 RHOST=${RHOST:=`hostname | awk {'print $1'}`}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 PID=$$

@@ -411,8 +414,8 @@ $trace_logic

     fi

-    [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-    echo "Test Failed: $@"
+    [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+    tst_resm TFAIL "Test Failed: $@"
     exit 1
 }

diff --git a/testcases/network/nfs/nfslock01/nfslock01 b/testcases/network/nfs/nfslock01/nfslock01
index 1e40073..8485d85 100755
--- a/testcases/network/nfs/nfslock01/nfslock01
+++ b/testcases/network/nfs/nfslock01/nfslock01
@@ -42,6 +42,9 @@ TCbin=${TCbin:=`pwd`}
 TCtmp=${TCtmp:=$TCbin/$TC$$}
 TCsrc=${TCsrc:=$TCbin}
 TClog=${TClog:=$TCtmp}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 mkdir $TCtmp >/dev/null 2>&1

@@ -129,8 +132,8 @@ end_testcase()
      do_cleanup
    fi

-   [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/nfs/nfsstat01/nfsstat01 b/testcases/network/nfs/nfsstat01/nfsstat01
index 9d52a45..0b68f7d 100755
--- a/testcases/network/nfs/nfsstat01/nfsstat01
+++ b/testcases/network/nfs/nfsstat01/nfsstat01
@@ -49,6 +49,9 @@ CLEANUP=${CLEANUP:="ON"}
 VERSION=${VERSION:=2}
 TESTDIR=${TESTDIR:=/tmp/$TC$PID.testdir}
 NFS_TYPE=${NFS_TYPE:nfs}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 if [ "x$NFS_TYPE" != "xnfs4" ]; then
     OPTS=${OPTS:="-o vers=$VERSION "}
@@ -236,8 +239,8 @@ $trace_logic
        do_cleanup
     fi

-    [ $? = 0 ] && { echo "Test PASS"; exit 0; }
-    echo "Test FAIL: $@"
+    [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+    tst_resm TFAIL "Test Failed: $@"
     exit 1
 }

diff --git a/testcases/network/nfs/nfsstress/nfsstress b/testcases/network/nfs/nfsstress/nfsstress
index 7f0006b..0826e57 100755
--- a/testcases/network/nfs/nfsstress/nfsstress
+++ b/testcases/network/nfs/nfsstress/nfsstress
@@ -49,6 +49,9 @@ TCsrc=${TCsrc:=$TCbin}
 TCtmp=${TCtmp:=$TCbin/$TC$$}
 TCdump=${TCdump:=$TCbin}
 RHOST=${RHOST:=`hostname|awk {'print $1'}`}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 # Setting the NFS to version 2 with UDP by default
 PID=$$
@@ -192,8 +195,8 @@ $trace_logic
 		 rsh -n $RHOST "rm -rf $TESTDIR"
     fi

-    [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-    echo "Test Failed: $@"
+    [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+    tst_resm TFAIL "Test Failed: $@"
     exit 1
 }

diff --git a/testcases/network/rpc/basic_tests/rpc01/rpc01 b/testcases/network/rpc/basic_tests/rpc01/rpc01
index ef97a95..fd236b1 100755
--- a/testcases/network/rpc/basic_tests/rpc01/rpc01
+++ b/testcases/network/rpc/basic_tests/rpc01/rpc01
@@ -43,6 +43,9 @@ NUMLOOPS=${NUMLOOPS:=3}
 RHOST=${RHOST:=`hostname`}
 CLEANUP=${CLEANUP:="ON"}
 DATAFILES=${DATAFILES:="file.1 file.2"}
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 #=============================================================================
 # FUNCTION NAME:        do_test
@@ -115,8 +118,8 @@ end_testcase()
    $trace_logic
    echo "$this_file: doing $0."

-   [ $# = 0 ] && { echo "Test Successful"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01 b/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01
index 11bdaca..7f8104f 100755
--- a/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01
+++ b/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01
@@ -65,6 +65,9 @@ LUSER=${LUSER:=root}
 RHOST=${RHOST:=`hostname`}
 CLEANUP=${CLEANUP:="ON"}
 PID=0
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 #=============================================================================
 # FUNCTION NAME:        do_test
@@ -273,8 +276,8 @@ end_testcase()
      do_cleanup
    fi

-   [ $# = 0 ] && { echo "Test Successfull"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/rpc/basic_tests/rup/rup01 b/testcases/network/rpc/basic_tests/rup/rup01
index 229a03f..5845528 100755
--- a/testcases/network/rpc/basic_tests/rup/rup01
+++ b/testcases/network/rpc/basic_tests/rup/rup01
@@ -54,6 +54,9 @@ LUSER=${LUSER:=root}
 RHOST=${RHOST:=`hostname`}
 CLEANUP=${CLEANUP:="ON"}
 PID=0
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 #=============================================================================
 # FUNCTION NAME:        do_test
@@ -158,8 +161,8 @@ end_testcase()
      do_cleanup
    fi

-   [ $# = 0 ] && { echo "Test Successfull"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

diff --git a/testcases/network/rpc/basic_tests/rusers/rusers01 b/testcases/network/rpc/basic_tests/rusers/rusers01
index 13c884a..0b28c9e 100755
--- a/testcases/network/rpc/basic_tests/rusers/rusers01
+++ b/testcases/network/rpc/basic_tests/rusers/rusers01
@@ -55,6 +55,9 @@ LUSER=${LUSER:=root}
 RHOST=${RHOST:=`hostname`}
 CLEANUP=${CLEANUP:="ON"}
 PID=0
+export TCID=$TC
+export TST_TOTAL=1
+export TST_COUNT=1

 #=============================================================================
 # FUNCTION NAME:        do_test
@@ -152,8 +155,8 @@ end_testcase()
      do_cleanup
    fi

-   [ $# = 0 ] && { echo "Test Successfull"; exit 0; }
-   echo "Test Failed: $@"
+   [ $# = 0 ] && { tst_resm TPASS "Test Successful"; exit 0; }
+   tst_resm TFAIL "Test Failed: $@"
    exit 1
 }

--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [LTP] [LNG][PATCH 2/8] ltp-networking/rpc: gave precise test name
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
@ 2013-11-14  3:38 ` Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 3/8] ltp-networking/nfs: use NFSv3 by default Vincent Hsu
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 .../network/rpc/basic_tests/rpcinfo/rpcinfo01      |    2 +-
 testcases/network/rpc/basic_tests/rup/rup01        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01 b/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01
index 7f8104f..cb063d8 100755
--- a/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01
+++ b/testcases/network/rpc/basic_tests/rpcinfo/rpcinfo01
@@ -57,7 +57,7 @@

 $trace_logic
 this_file=${0##*/}
-TC=rusers
+TC=rpcinfo01
 TCtmp=${TCtmp:=`pwd`}
 TCbin=${TCbin:=`pwd`}
 TCsrc=${TCsrc:=$TCbin}
diff --git a/testcases/network/rpc/basic_tests/rup/rup01 b/testcases/network/rpc/basic_tests/rup/rup01
index 5845528..99916d4 100755
--- a/testcases/network/rpc/basic_tests/rup/rup01
+++ b/testcases/network/rpc/basic_tests/rup/rup01
@@ -46,7 +46,7 @@

 $trace_logic
 this_file=${0##*/}
-TC=rusers
+TC=rup01
 TCtmp=${TCtmp:=`pwd`}
 TCbin=${TCbin:=`pwd`}
 TCsrc=${TCsrc:=$TCbin}
--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [LTP] [LNG][PATCH 3/8] ltp-networking/nfs: use NFSv3 by default
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 2/8] ltp-networking/rpc: gave precise test name Vincent Hsu
@ 2013-11-14  3:38 ` Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 4/8] ltp-networking/nfs: remove absolute path for showmount Vincent Hsu
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

NFSv3 is more compatible with recent linux distributions.

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/nfs/fsx-linux/fsx.sh    |    2 +-
 testcases/network/nfs/nfs01/nfs01         |    2 +-
 testcases/network/nfs/nfs02/nfs02         |    2 +-
 testcases/network/nfs/nfs03/nfs03         |    4 ++--
 testcases/network/nfs/nfs04/nfs04         |    2 +-
 testcases/network/nfs/nfsstat01/nfsstat01 |    2 +-
 testcases/network/nfs/nfsstress/nfsstress |    4 ++--
 7 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/testcases/network/nfs/fsx-linux/fsx.sh b/testcases/network/nfs/fsx-linux/fsx.sh
index fddaf03..facc708 100755
--- a/testcases/network/nfs/fsx-linux/fsx.sh
+++ b/testcases/network/nfs/fsx-linux/fsx.sh
@@ -78,7 +78,7 @@ $trace_logic

     PID=$$

-    VERSION=${VERSION:=2}
+    VERSION=${VERSION:=3}
     RHOST=${RHOST:=`hostname`}
     ITERATIONS=${ITERATIONS:=50000}
     SOCKET_TYPE=${SOCKET_TYPE:=udp}
diff --git a/testcases/network/nfs/nfs01/nfs01 b/testcases/network/nfs/nfs01/nfs01
index 1a942c4..77d2775 100755
--- a/testcases/network/nfs/nfs01/nfs01
+++ b/testcases/network/nfs/nfs01/nfs01
@@ -75,7 +75,7 @@ $trace_logic

     PID=$$

-    VERSION=${VERSION:=2}
+    VERSION=${VERSION:=3}
     RHOST=${RHOST:=`hostname`}
     NFILES=${NFILES:=1000}
     SOCKET_TYPE=${SOCKET_TYPE:=udp}
diff --git a/testcases/network/nfs/nfs02/nfs02 b/testcases/network/nfs/nfs02/nfs02
index ab0e3c7..89b65cf 100755
--- a/testcases/network/nfs/nfs02/nfs02
+++ b/testcases/network/nfs/nfs02/nfs02
@@ -53,7 +53,7 @@ export TST_COUNT=1
 PID=$$

 RHOST=${RHOST:=`hostname`}
-VERSION=${VERSION:=2}
+VERSION=${VERSION:=3}
 SOCKET_TYPE=${SOCKET_TYPE:=udp}
 TESTDIR=${TESTDIR:=/tmp/$TC$PID.testdir}
 CLEANUP=${CLEANUP:="ON"}
diff --git a/testcases/network/nfs/nfs03/nfs03 b/testcases/network/nfs/nfs03/nfs03
index 445c6ae..a6c53ab 100755
--- a/testcases/network/nfs/nfs03/nfs03
+++ b/testcases/network/nfs/nfs03/nfs03
@@ -55,8 +55,8 @@ export TST_COUNT=1

 PID=$$

-# Setting the NFS to version 2 by default
-VERSION=${VERSION:=2}
+# Setting the NFS to version 3 by default
+VERSION=${VERSION:=3}
 SOCKET_TYPE=${SOCKET_TYPE:=udp}
 TESTDIR=${TESTDIR:=/tmp/$TC$PID.testdir}
 NFS_TYPE=${NFS_TYPE:=nfs}
diff --git a/testcases/network/nfs/nfs04/nfs04 b/testcases/network/nfs/nfs04/nfs04
index 3289f0e..7518d5b 100755
--- a/testcases/network/nfs/nfs04/nfs04
+++ b/testcases/network/nfs/nfs04/nfs04
@@ -71,7 +71,7 @@ $trace_logic

     PID=$$

-    VERSION=${VERSION:=2}
+    VERSION=${VERSION:=3}
     RHOST=${RHOST:=`hostname`}
     FILESIZE=${FILESIZE:=10}
     SOCKET_TYPE=${SOCKET_TYPE:=udp}
diff --git a/testcases/network/nfs/nfsstat01/nfsstat01 b/testcases/network/nfs/nfsstat01/nfsstat01
index 0b68f7d..7b1ac43 100755
--- a/testcases/network/nfs/nfsstat01/nfsstat01
+++ b/testcases/network/nfs/nfsstat01/nfsstat01
@@ -46,7 +46,7 @@ TCbin=${TCbin:=`pwd`}
 EXPORTDIR=${EXPORTDIR:=/tmp/$TC$PID}
 HOST=`hostname`
 CLEANUP=${CLEANUP:="ON"}
-VERSION=${VERSION:=2}
+VERSION=${VERSION:=3}
 TESTDIR=${TESTDIR:=/tmp/$TC$PID.testdir}
 NFS_TYPE=${NFS_TYPE:nfs}
 export TCID=$TC
diff --git a/testcases/network/nfs/nfsstress/nfsstress b/testcases/network/nfs/nfsstress/nfsstress
index 0826e57..3e078d9 100755
--- a/testcases/network/nfs/nfsstress/nfsstress
+++ b/testcases/network/nfs/nfsstress/nfsstress
@@ -53,9 +53,9 @@ export TCID=$TC
 export TST_TOTAL=1
 export TST_COUNT=1

-# Setting the NFS to version 2 with UDP by default
+# Setting the NFS to version 3 with UDP by default
 PID=$$
-VERSION=${VERSION:=2}
+VERSION=${VERSION:=3}
 SOCKET_TYPE=${SOCKET_TYPE:=udp}
 TESTDIR=${TESTDIR:=/tmp/$TC$PID.testdir}
 NFS_TYPE=${NFS_TYPE:=nfs}
--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [LTP] [LNG][PATCH 4/8] ltp-networking/nfs: remove absolute path for showmount.
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 2/8] ltp-networking/rpc: gave precise test name Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 3/8] ltp-networking/nfs: use NFSv3 by default Vincent Hsu
@ 2013-11-14  3:38 ` Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 5/8] ltp-networking/nfs: fix nfsstat01 typo Vincent Hsu
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

Showmount doesn't locate at /user/sbin/showmount on Ubuntu 12.04.

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/nfs/nfs02/nfs02         |    2 +-
 testcases/network/nfs/nfsstat01/nfsstat01 |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/network/nfs/nfs02/nfs02 b/testcases/network/nfs/nfs02/nfs02
index 89b65cf..c192d96 100755
--- a/testcases/network/nfs/nfs02/nfs02
+++ b/testcases/network/nfs/nfs02/nfs02
@@ -103,7 +103,7 @@ $trace_logic
    fi

    #Verify export
-   /usr/sbin/showmount -e $RHOST | grep $TESTDIR
+   showmount -e $RHOST | grep $TESTDIR
    [ $? -eq 0 ] || end_testcase "$TESTDIR not exported"

    #Create $TCtmp for mount point
diff --git a/testcases/network/nfs/nfsstat01/nfsstat01 b/testcases/network/nfs/nfsstat01/nfsstat01
index 7b1ac43..f08f758 100755
--- a/testcases/network/nfs/nfsstat01/nfsstat01
+++ b/testcases/network/nfs/nfsstat01/nfsstat01
@@ -100,7 +100,7 @@ $trace_logic
    fi

    #Verify export
-   /usr/sbin/showmount -e $HOST | grep $EXPORTDIR > /dev/null
+   showmount -e $HOST | grep $EXPORTDIR > /dev/null
    [ $? -eq 0 ] || end_testcase "$EXPORTDIR not exported"

    #Create mount point
--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [LTP] [LNG][PATCH 5/8] ltp-networking/nfs: fix nfsstat01 typo
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
                   ` (2 preceding siblings ...)
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 4/8] ltp-networking/nfs: remove absolute path for showmount Vincent Hsu
@ 2013-11-14  3:38 ` Vincent Hsu
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 6/8] ltp-networking/tcp_cmds/finger: fix finger test Vincent Hsu
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/nfs/nfsstat01/nfsstat01 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/network/nfs/nfsstat01/nfsstat01 b/testcases/network/nfs/nfsstat01/nfsstat01
index f08f758..229e2c3 100755
--- a/testcases/network/nfs/nfsstat01/nfsstat01
+++ b/testcases/network/nfs/nfsstat01/nfsstat01
@@ -48,7 +48,7 @@ HOST=`hostname`
 CLEANUP=${CLEANUP:="ON"}
 VERSION=${VERSION:=3}
 TESTDIR=${TESTDIR:=/tmp/$TC$PID.testdir}
-NFS_TYPE=${NFS_TYPE:nfs}
+NFS_TYPE=${NFS_TYPE:=nfs}
 export TCID=$TC
 export TST_TOTAL=1
 export TST_COUNT=1
--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [LTP] [LNG][PATCH 6/8] ltp-networking/tcp_cmds/finger: fix finger test
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
                   ` (3 preceding siblings ...)
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 5/8] ltp-networking/nfs: fix nfsstat01 typo Vincent Hsu
@ 2013-11-14  3:38 ` Vincent Hsu
  2013-11-26 13:33   ` chrubis
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 7/8] ltp-networking/tcp_cmds/netstat: fix netstat test Vincent Hsu
                   ` (2 subsequent siblings)
  7 siblings, 1 reply; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

Ubuntu use modified finger command. finger an unknown host test will
return nonzero on Ubuntu 12.04 even if execution success.

for example:
in Ubuntu
    finger @xxx 2>&1 1>/dev/null ; echo $?
will return
    finger: unknown host: xxx
    getaddrinfo: No address associated with hostname
    1
in CentOS
    finger @xxx 2>&1 1>/dev/null ; echo $?
will return
    finger: xxx: nodename nor servname provided, or not known
    0

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/tcp_cmds/finger/finger01 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/network/tcp_cmds/finger/finger01 b/testcases/network/tcp_cmds/finger/finger01
index 6a72c8f..a5206be 100755
--- a/testcases/network/tcp_cmds/finger/finger01
+++ b/testcases/network/tcp_cmds/finger/finger01
@@ -116,8 +116,8 @@ do_test2()

     tst_resm TINFO "finger -bad user "
     finger $BADUSER 2>&1 1>/dev/null || end_testcase "finger $BADUSER"
-    finger @$BADHOST 2>&1 1>/dev/null || end_testcase "finger @$BADHOST"
-    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null; then
+    finger @$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host" || end_testcase "finger @$BADHOST"
+    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host"; then
         end_testcase "finger $BADUSER@$BADHOST"
     fi
 }
--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [LTP] [LNG][PATCH 6/8] ltp-networking/tcp_cmds/finger: fix finger test
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 6/8] ltp-networking/tcp_cmds/finger: fix finger test Vincent Hsu
@ 2013-11-26 13:33   ` chrubis
  0 siblings, 0 replies; 13+ messages in thread
From: chrubis @ 2013-11-26 13:33 UTC (permalink / raw)
  To: Vincent Hsu; +Cc: ltp-list, linaro-networking

Hi!
> Ubuntu use modified finger command. finger an unknown host test will
> return nonzero on Ubuntu 12.04 even if execution success.
> 
> for example:
> in Ubuntu
>     finger @xxx 2>&1 1>/dev/null ; echo $?
> will return
>     finger: unknown host: xxx
>     getaddrinfo: No address associated with hostname
>     1
> in CentOS
>     finger @xxx 2>&1 1>/dev/null ; echo $?
> will return
>     finger: xxx: nodename nor servname provided, or not known
>     0
> 
> Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
> ---
>  testcases/network/tcp_cmds/finger/finger01 |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/network/tcp_cmds/finger/finger01 b/testcases/network/tcp_cmds/finger/finger01
> index 6a72c8f..a5206be 100755
> --- a/testcases/network/tcp_cmds/finger/finger01
> +++ b/testcases/network/tcp_cmds/finger/finger01
> @@ -116,8 +116,8 @@ do_test2()
> 
>      tst_resm TINFO "finger -bad user "
>      finger $BADUSER 2>&1 1>/dev/null || end_testcase "finger $BADUSER"
> -    finger @$BADHOST 2>&1 1>/dev/null || end_testcase "finger @$BADHOST"
> -    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null; then
> +    finger @$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host" || end_testcase "finger @$BADHOST"
> +    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host"; then
>          end_testcase "finger $BADUSER@$BADHOST"
>      fi
>  }

The same as the last one, please fix the over 80 chars line.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [LTP] [LNG][PATCH 7/8] ltp-networking/tcp_cmds/netstat: fix netstat test
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
                   ` (4 preceding siblings ...)
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 6/8] ltp-networking/tcp_cmds/finger: fix finger test Vincent Hsu
@ 2013-11-14  3:38 ` Vincent Hsu
  2013-11-15  6:27   ` Caspar Zhang
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 8/8] ltp-networking/iproute: fix iproute test Vincent Hsu
  2013-11-26 13:34 ` [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message chrubis
  7 siblings, 1 reply; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

The netstat command will return nozero on Ubuntu 12.04 even if
execution success.

for example:
in Ubuntu
    $ netstat -s 1>/dev/null 2>&1 ; echo $?
    1
in CentOS
    $ netstat -s 1>/dev/null 2>&1 ; echo $?
    0

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/tcp_cmds/netstat/netstat01 |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testcases/network/tcp_cmds/netstat/netstat01 b/testcases/network/tcp_cmds/netstat/netstat01
index 3c2d1bb..6d4682a 100755
--- a/testcases/network/tcp_cmds/netstat/netstat01
+++ b/testcases/network/tcp_cmds/netstat/netstat01
@@ -58,7 +58,8 @@ do_test() {
     while [ $TST_COUNT -le $NUMLOOPS ]; do

         for flag in "-s" "-rn" "-i" "-gn" "-apn"; do
-            if ! netstat $flag 1>/dev/null 2>&1; then
+            var=$(netstat $flag 1>/dev/null 2>&1);
+            if [ "$var" != "" ]; then
                 end_testcase "netstat $flag failed"
             fi
         done
--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [LTP] [LNG][PATCH 7/8] ltp-networking/tcp_cmds/netstat: fix netstat test
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 7/8] ltp-networking/tcp_cmds/netstat: fix netstat test Vincent Hsu
@ 2013-11-15  6:27   ` Caspar Zhang
  2013-11-26 12:56     ` chrubis
  0 siblings, 1 reply; 13+ messages in thread
From: Caspar Zhang @ 2013-11-15  6:27 UTC (permalink / raw)
  To: Vincent Hsu, ltp-list; +Cc: linaro-networking

On 11/14/2013 11:38 AM, Vincent Hsu wrote:
> The netstat command will return nozero on Ubuntu 12.04 even if
> execution success.
>
> for example:
> in Ubuntu
>      $ netstat -s 1>/dev/null 2>&1 ; echo $?
>      1
> in CentOS
>      $ netstat -s 1>/dev/null 2>&1 ; echo $?
>      0
>
> Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>

This should be a bug in netstat @ Ubuntu I guess?

Caspar

> ---
>   testcases/network/tcp_cmds/netstat/netstat01 |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/network/tcp_cmds/netstat/netstat01 b/testcases/network/tcp_cmds/netstat/netstat01
> index 3c2d1bb..6d4682a 100755
> --- a/testcases/network/tcp_cmds/netstat/netstat01
> +++ b/testcases/network/tcp_cmds/netstat/netstat01
> @@ -58,7 +58,8 @@ do_test() {
>       while [ $TST_COUNT -le $NUMLOOPS ]; do
>
>           for flag in "-s" "-rn" "-i" "-gn" "-apn"; do
> -            if ! netstat $flag 1>/dev/null 2>&1; then
> +            var=$(netstat $flag 1>/dev/null 2>&1);
> +            if [ "$var" != "" ]; then
>                   end_testcase "netstat $flag failed"
>               fi
>           done
> --
> 1.7.9.5
>
>
> ------------------------------------------------------------------------------
> DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
> OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
> Free app hosting. Or install the open source package on any LAMP server.
> Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
> http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [LTP] [LNG][PATCH 7/8] ltp-networking/tcp_cmds/netstat: fix netstat test
  2013-11-15  6:27   ` Caspar Zhang
@ 2013-11-26 12:56     ` chrubis
  0 siblings, 0 replies; 13+ messages in thread
From: chrubis @ 2013-11-26 12:56 UTC (permalink / raw)
  To: Caspar Zhang; +Cc: ltp-list, Vincent Hsu, linaro-networking

Hi!
> > The netstat command will return nozero on Ubuntu 12.04 even if
> > execution success.
> >
> > for example:
> > in Ubuntu
> >      $ netstat -s 1>/dev/null 2>&1 ; echo $?
> >      1
> > in CentOS
> >      $ netstat -s 1>/dev/null 2>&1 ; echo $?
> >      0
> >
> > Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
> 
> This should be a bug in netstat @ Ubuntu I guess?

Looks like a bug in Debian to me, I've looked into the source package
and traced it down to the netstat.c-assorted_changes.patch, that seems
to add ipv6 support and changes the exit(0) to exit(1) for no good
reason.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [LTP] [LNG][PATCH 8/8] ltp-networking/iproute: fix iproute test
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
                   ` (5 preceding siblings ...)
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 7/8] ltp-networking/tcp_cmds/netstat: fix netstat test Vincent Hsu
@ 2013-11-14  3:38 ` Vincent Hsu
  2013-11-26 13:31   ` chrubis
  2013-11-26 13:34 ` [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message chrubis
  7 siblings, 1 reply; 13+ messages in thread
From: Vincent Hsu @ 2013-11-14  3:38 UTC (permalink / raw)
  To: ltp-list; +Cc: linaro-networking

ip02: set original mtu size back. this test will set mtu to 300.
ip05: if there is not only one route, using "head" command will get
      wrong result.

Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
---
 testcases/network/iproute/ip_tests.sh |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/testcases/network/iproute/ip_tests.sh b/testcases/network/iproute/ip_tests.sh
index ce4cabc..e16f6c4 100755
--- a/testcases/network/iproute/ip_tests.sh
+++ b/testcases/network/iproute/ip_tests.sh
@@ -187,6 +187,7 @@ test01()

 	tst_resm TINFO "Test #1: changing mtu size of eth0:1 device."

+	MTUSZ_BAK=`ifconfig eth0:1 | grep -i MTU | sed "s/^.*MTU://" | awk '{print $1}'`
 	ip link set eth0:1 mtu 300 >$LTPTMP/tst_ip.err 2>&1
 	if [ $RC -ne 0 ]
 	then
@@ -198,6 +199,7 @@ test01()
 		if [ $MTUSZ -eq 300 ]
 		then
 			tst_resm TPASS "Test #1: changing mtu size success"
+			ip link set eth0:1 mtu $MTUSZ_BAK >$LTPTMP/tst_ip.err 2>&1
 		else
 			tst_resm FAIL NULL \
 				"Test #1: MTU value not set to 300: ifconfig returned: $MTUSZ"
@@ -453,7 +455,8 @@ test05()
 		10.6.6.6 via 127.0.0.1 dev lo
 		EOF

-		ip route show | head -n1 >$LTPTMP/tst_ip.out 2>&1 || RC=$?
+		ip route show | grep "10.6.6.6 via 127.0.0.1 dev lo" \
+		>$LTPTMP/tst_ip.out 2>&1 || RC=$?
 		if [ $RC -ne 0 ]
 		then
 			tst_res TFAIL $LTPTMP/tst_ip.err \
--
1.7.9.5


------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [LTP] [LNG][PATCH 8/8] ltp-networking/iproute: fix iproute test
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 8/8] ltp-networking/iproute: fix iproute test Vincent Hsu
@ 2013-11-26 13:31   ` chrubis
  0 siblings, 0 replies; 13+ messages in thread
From: chrubis @ 2013-11-26 13:31 UTC (permalink / raw)
  To: Vincent Hsu; +Cc: ltp-list, linaro-networking

Hi!
> ip02: set original mtu size back. this test will set mtu to 300.
> ip05: if there is not only one route, using "head" command will get
>       wrong result.
> 
> Signed-off-by: Vincent Hsu <vincent.hsu@linaro.org>
> ---
>  testcases/network/iproute/ip_tests.sh |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/network/iproute/ip_tests.sh b/testcases/network/iproute/ip_tests.sh
> index ce4cabc..e16f6c4 100755
> --- a/testcases/network/iproute/ip_tests.sh
> +++ b/testcases/network/iproute/ip_tests.sh
> @@ -187,6 +187,7 @@ test01()
> 
>  	tst_resm TINFO "Test #1: changing mtu size of eth0:1 device."
> 
> +	MTUSZ_BAK=`ifconfig eth0:1 | grep -i MTU | sed "s/^.*MTU://" | awk '{print $1}'`
>  	ip link set eth0:1 mtu 300 >$LTPTMP/tst_ip.err 2>&1
>  	if [ $RC -ne 0 ]
>  	then
> @@ -198,6 +199,7 @@ test01()
>  		if [ $MTUSZ -eq 300 ]
>  		then
>  			tst_resm TPASS "Test #1: changing mtu size success"
> +			ip link set eth0:1 mtu $MTUSZ_BAK >$LTPTMP/tst_ip.err 2>&1
>  		else
>  			tst_resm FAIL NULL \
>  				"Test #1: MTU value not set to 300: ifconfig returned: $MTUSZ"
> @@ -453,7 +455,8 @@ test05()
>  		10.6.6.6 via 127.0.0.1 dev lo
>  		EOF
> 
> -		ip route show | head -n1 >$LTPTMP/tst_ip.out 2>&1 || RC=$?
> +		ip route show | grep "10.6.6.6 via 127.0.0.1 dev lo" \
> +		>$LTPTMP/tst_ip.out 2>&1 || RC=$?
>  		if [ $RC -ne 0 ]
>  		then
>  			tst_res TFAIL $LTPTMP/tst_ip.err \

Can you please fix the two over 80 chars lines that your patch adds?

Otherwise this is fine.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message
  2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
                   ` (6 preceding siblings ...)
  2013-11-14  3:38 ` [LTP] [LNG][PATCH 8/8] ltp-networking/iproute: fix iproute test Vincent Hsu
@ 2013-11-26 13:34 ` chrubis
  7 siblings, 0 replies; 13+ messages in thread
From: chrubis @ 2013-11-26 13:34 UTC (permalink / raw)
  To: Vincent Hsu; +Cc: ltp-list, linaro-networking

Hi!
All but the last three patches are pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2013-11-26 13:34 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-14  3:38 [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message Vincent Hsu
2013-11-14  3:38 ` [LTP] [LNG][PATCH 2/8] ltp-networking/rpc: gave precise test name Vincent Hsu
2013-11-14  3:38 ` [LTP] [LNG][PATCH 3/8] ltp-networking/nfs: use NFSv3 by default Vincent Hsu
2013-11-14  3:38 ` [LTP] [LNG][PATCH 4/8] ltp-networking/nfs: remove absolute path for showmount Vincent Hsu
2013-11-14  3:38 ` [LTP] [LNG][PATCH 5/8] ltp-networking/nfs: fix nfsstat01 typo Vincent Hsu
2013-11-14  3:38 ` [LTP] [LNG][PATCH 6/8] ltp-networking/tcp_cmds/finger: fix finger test Vincent Hsu
2013-11-26 13:33   ` chrubis
2013-11-14  3:38 ` [LTP] [LNG][PATCH 7/8] ltp-networking/tcp_cmds/netstat: fix netstat test Vincent Hsu
2013-11-15  6:27   ` Caspar Zhang
2013-11-26 12:56     ` chrubis
2013-11-14  3:38 ` [LTP] [LNG][PATCH 8/8] ltp-networking/iproute: fix iproute test Vincent Hsu
2013-11-26 13:31   ` chrubis
2013-11-26 13:34 ` [LTP] [LNG][PATCH 1/8] ltp-networking: standardize test result message chrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox