From: chrubis@suse.cz
To: Vincent Hsu <vincent.hsu@linaro.org>
Cc: ltp-list@lists.sourceforge.net, linaro-networking@linaro.org
Subject: Re: [LTP] [LNG][PATCH V2 0/2] fixing over 80 chars
Date: Tue, 10 Dec 2013 14:57:10 +0100 [thread overview]
Message-ID: <20131210135709.GB25334@rei> (raw)
In-Reply-To: <1385534272-32414-1-git-send-email-vincent.hsu@linaro.org>
Hi!
> I've fixed the over 80 characters lines that my patches adds,
> but there are other lines over 80 chars in the same file.
> eg.
> checkpatch.pl -f testcases/network/iproute/ip_tests.sh
> ....
> WARNING: line over 80 characters
> #575: FILE: network/iproute/ip_tests.sh:575:
> + ip maddr show | grep "66:66:00:00:00:66" &>$LTPTMP/tst_ip.err \
> total: 0 errors, 22 warnings, 611 lines checked
>
> BTW, some test files combine spaces and tabs for indentation, and also have
> over 80 chars lines.
> eg.
> testcases/network/multicast/*
> testcases/network/nfs/*
>
> Maybe you could clean up them when you have time :)
There is a lot of legacy and messed up code and we are fixing it as fast
as we can...
But in order to get somewhere newly added code should be clean,
otherwise we will never get to a clean codebase.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-12-10 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 6:37 [LTP] [LNG][PATCH V2 0/2] fixing over 80 chars Vincent Hsu
2013-11-27 6:37 ` [LTP] [LNG][PATCH V2 1/2] ltp-networking/tcp_cmds/finger: fix finger test Vincent Hsu
2013-11-27 6:37 ` [LTP] [LNG][PATCH V2 2/2] ltp-networking/iproute: fix iproute test Vincent Hsu
2013-12-10 15:29 ` chrubis
2013-12-10 13:57 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210135709.GB25334@rei \
--to=chrubis@suse.cz \
--cc=linaro-networking@linaro.org \
--cc=ltp-list@lists.sourceforge.net \
--cc=vincent.hsu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox