Re: [LTP] [PATCH v2] utils: sctp: Fix build for prefixed architectures

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 2140 bytes --]

On Friday 20 December 2013 07:45:17 Markos Chandras wrote:
> On 12/16/2013 06:58 AM, Mike Frysinger wrote:
> > On Friday 13 December 2013 07:31:02 Markos Chandras wrote:
> >> Commit 6f22494d19b605ded308dc0fa713e91cb873f44a
> >> "Move sctp to utils and bump it to 1.0.15"
> >> 
> >> introduced a build failure for the prefixed architectures.
> >> We need to take into consideration the __USER_LABEL_PREFIX__
> >> for architectures that define it when creating symbol aliases.
> >> 
> >> The following upstream patch (0600c8968cc2dea04cbf13ec739216e2939d08fe)
> >> fixes the build for the Meta(metag) architecture
> >> 
> >> [...]
> >> utils/sctp/func_tests/test_connectx.c:151: undefined reference to
> >> `_sctp_connectx' utils/sctp/func_tests/test_connectx.c:163: undefined
> >> reference to `_sctp_connectx' [...]
> >> 
> >> Build tested on x86_64 and metag.
> > 
> > we really should fix this instead by not using any symbol renaming. 
> > symbol versions might make sense when dealing with a released project
> > and a stable shared library API, but it makes no sense in LTP.
> > 
> > perhaps better to have a compile time knob to disable it all ?
> > -mike
> 
> Well whatever works best. Personally I would avoid deviating from
> third-party code unless it's really necessary.

sure, but i'm not sure this change covers everything

there's still:
extern int sctp_connectx_orig (int)
    __attribute ((alias ("__sctp_connectx")));

i vaguely recall gcc doesn't add symbol prefixes to the alias attribute.  the 
documentation implies that too:

The alias attribute causes the declaration to be emitted as an alias for 
another symbol, which must be specified. For instance,
          void __f () { /* Do something. */; }
          void f () __attribute__ ((weak, alias ("__f")));
defines ‘f’ to be a weak alias for ‘__f’. In C++, the mangled name for the 
target must be used. It is an error if ‘__f’ is not defined in the same 
translation unit.

since this still needs fixing upstream, might be a good time to also include a 
knob to turn this crap off entirely ? :)
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 455 bytes --]

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list