public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net,
	Markos Chandras <Markos.Chandras@imgtec.com>
Subject: Re: [LTP] [PATCH v2] utils: sctp: Fix build for prefixed architectures
Date: Wed, 8 Jan 2014 14:30:24 +0100	[thread overview]
Message-ID: <20140108133024.GA1340@rei> (raw)
In-Reply-To: <201401051730.25397.vapier@gentoo.org>

Hi!
> sure, but i'm not sure this change covers everything
> 
> there's still:
> extern int sctp_connectx_orig (int)
>     __attribute ((alias ("__sctp_connectx")));
> 
> i vaguely recall gcc doesn't add symbol prefixes to the alias attribute.  the 
> documentation implies that too:
> 
> The alias attribute causes the declaration to be emitted as an alias for 
> another symbol, which must be specified. For instance,
>           void __f () { /* Do something. */; }
>           void f () __attribute__ ((weak, alias ("__f")));
> defines ???f??? to be a weak alias for ???__f???. In C++, the mangled name for the 
> target must be used. It is an error if ???__f??? is not defined in the same 
> translation unit.
> 
> since this still needs fixing upstream, might be a good time to also include a 
> knob to turn this crap off entirely ? :)

What is the status? This is a build failure and so should be fixed
before the release which should happen soon enough (generally right
after we get rid of build failures on older distros and exotic
hardware).

We have a few options here:

* Apply the patch that is not clean but was applied in upstream

* Disable the sctp build temporarily

* Fix this correctly (and I'm not going to do this myself)

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2014-01-08 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 12:31 [LTP] [PATCH v2] utils: sctp: Fix build for prefixed architectures Markos Chandras
2013-12-16  6:58 ` Mike Frysinger
2013-12-20 12:45   ` Markos Chandras
2014-01-05 22:30     ` Mike Frysinger
2014-01-08 13:30       ` chrubis [this message]
     [not found]         ` <201401081644.28915.vapier@gentoo.org>
2014-01-09 11:57           ` chrubis
2014-01-09 11:53 ` chrubis
     [not found]   ` <52CE9B15.4070307@imgtec.com>
     [not found]     ` <52CFC57F.9000004@imgtec.com>
2014-01-13 18:54       ` chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108133024.GA1340@rei \
    --to=chrubis@suse.cz \
    --cc=Markos.Chandras@imgtec.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox