Re: [LTP] [PATCH v2] ptrace: Fix build problems with glibc-2.18

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1696 bytes --]

On Wednesday 08 January 2014 06:50:43 Markos Chandras wrote:
> On 01/06/2014 12:49 PM, Mike Frysinger wrote:
> > On Monday 06 January 2014 06:45:43 Markos Chandras wrote:
> >> On 01/05/2014 10:27 PM, Mike Frysinger wrote:
> >>> On Monday 25 November 2013 05:12:59 Markos Chandras wrote:
> >>>> Since glibc-2.18, the struct ptrace_peeksiginfo_args is
> >>>> also defined in sys/ptrace.h and conflicts with the definition
> >>>> from the Linux kernel in linux/ptrace.h. We fix this by not
> >>>> including the linux/ptrace.h header if the sys/ptrace.h header
> >>>> defines the said struct. Fixes
> >>>> https://github.com/linux-test-project/ltp/issues/6
> >>> 
> >>> i'm somewhat inclined to undo this as it's really a bug in glibc-2.18
> >>> 
> >>> that should be fixed in glibc-2.19:
> >>> 	https://sourceware.org/ml/libc-alpha/2014-01/msg00078.html
> >> 
> >> Ehm that would break the build for people already using 2.18. Even if a
> >> new 2.18 is released with the fix, people using the old one will still
> >> face the same problem.
> > 
> > i'm aware that would be the situation.  i'm fine with that.
> 
> It's not my call to make, but forcing people to update their glibc in
> order to build LTP is a bit too much. I suggest to keep this workaround
> for X months, until more people have been moved to a fixed glibc version.

i'm not forcing people to update their glibc.  i am forcing them to get their 
distro to land a simple fix.  or run a simple sed script as root to fix their 
header.

> strace also has similar fix
> http://sourceforge.net/p/strace/code/ci/0b4060f61f1bb101b5d8d084714b7d2feac
> db199/

yes, and i already commented there
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 455 bytes --]

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list