public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] ptrace: Fix build problems with glibc-2.18
Date: Wed, 8 Jan 2014 16:22:59 +0100	[thread overview]
Message-ID: <20140108152259.GB1556@rei> (raw)
In-Reply-To: <201401051727.10564.vapier@gentoo.org>

Hi!
> > Since glibc-2.18, the struct ptrace_peeksiginfo_args is
> > also defined in sys/ptrace.h and conflicts with the definition
> > from the Linux kernel in linux/ptrace.h. We fix this by not
> > including the linux/ptrace.h header if the sys/ptrace.h header
> > defines the said struct. Fixes
> > https://github.com/linux-test-project/ltp/issues/6
> 
> i'm somewhat inclined to undo this as it's really a bug in glibc-2.18 that 
> should be fixed in glibc-2.19:
> 	https://sourceware.org/ml/libc-alpha/2014-01/msg00078.html

Let's keep it for the next release (which will happen anytime soon). The
ptrace tests are messy and the ptrace.h needs to be fixed anyway.

Or do you insist on removing it before the release? I don't like that
idea much but I can change my opinion if you provide reasonable
arguments.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2014-01-08 15:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 10:12 [LTP] [PATCH v2] ptrace: Fix build problems with glibc-2.18 Markos Chandras
2013-12-02  9:31 ` Markos Chandras
2013-12-02 17:35   ` chrubis
2013-12-02 17:52 ` chrubis
2014-01-05 22:27 ` Mike Frysinger
2014-01-06 11:45   ` Markos Chandras
2014-01-06 12:49     ` Mike Frysinger
2014-01-08 11:50       ` Markos Chandras
2014-01-08 19:41         ` Mike Frysinger
2014-01-08 15:22   ` chrubis [this message]
     [not found]     ` <201401081442.11349.vapier@gentoo.org>
2014-01-09 11:58       ` chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108152259.GB1556@rei \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox