Re: [LTP] [PATCH] setregid02: invalid user value fix

[chrubis@suse.cz]

Hi!
> Commit 705926d096f7a64c9d53efeb789288e25457d68f
> introduced a bug that the value for inval_user was treated
> as '-1' when passed to 16-bit version of setregid().
> 
> Fixed it the same way as it's done for setreuid test cases.
> 
> Reported-by: Honggyu Kim <hong.gyu.kim@lge.com>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
>  testcases/kernel/syscalls/setregid/setregid02.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/setregid/setregid02.c b/testcases/kernel/syscalls/setregid/setregid02.c
> index e67a7df..2b84b26 100644
> --- a/testcases/kernel/syscalls/setregid/setregid02.c
> +++ b/testcases/kernel/syscalls/setregid/setregid02.c
> @@ -39,7 +39,7 @@ TCID_DEFINE(setregid02);
>  
>  static gid_t neg_one = -1;
>  
> -static gid_t inval_user = (USHRT_MAX);
> +static gid_t inval_user = USHRT_MAX - 2;
>  static struct passwd *ltpuser;

Unfortunately I've found that in SLES user nobody has UID precisely
USHRT_MAX - 2 and the test fails :(

Thinking of correct solution, we probably need some
tst_get_unused_uid(). What do you think?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list