[LTP] [PATCH] setregid02: invalid user value fix

[LTP] [PATCH] setregid02: invalid user value fix

[Stanislav Kholmanskikh]

Commit 705926d096f7a64c9d53efeb789288e25457d68f
introduced a bug that the value for inval_user was treated
as '-1' when passed to 16-bit version of setregid().

Fixed it the same way as it's done for setreuid test cases.

Reported-by: Honggyu Kim <hong.gyu.kim@lge.com>
Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 testcases/kernel/syscalls/setregid/setregid02.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/setregid/setregid02.c b/testcases/kernel/syscalls/setregid/setregid02.c
index e67a7df..2b84b26 100644
--- a/testcases/kernel/syscalls/setregid/setregid02.c
+++ b/testcases/kernel/syscalls/setregid/setregid02.c
@@ -39,7 +39,7 @@ TCID_DEFINE(setregid02);
 
 static gid_t neg_one = -1;
 
-static gid_t inval_user = (USHRT_MAX);
+static gid_t inval_user = USHRT_MAX - 2;
 static struct passwd *ltpuser;
 
 static struct group nobody, root, bin;
-- 
1.7.1


------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] setregid02: invalid user value fix

[chrubis]

Hi!
> Commit 705926d096f7a64c9d53efeb789288e25457d68f
> introduced a bug that the value for inval_user was treated
> as '-1' when passed to 16-bit version of setregid().
> 
> Fixed it the same way as it's done for setreuid test cases.

Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] setregid02: invalid user value fix

[chrubis]

Hi!
> Commit 705926d096f7a64c9d53efeb789288e25457d68f
> introduced a bug that the value for inval_user was treated
> as '-1' when passed to 16-bit version of setregid().
> 
> Fixed it the same way as it's done for setreuid test cases.
> 
> Reported-by: Honggyu Kim <hong.gyu.kim@lge.com>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
>  testcases/kernel/syscalls/setregid/setregid02.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/setregid/setregid02.c b/testcases/kernel/syscalls/setregid/setregid02.c
> index e67a7df..2b84b26 100644
> --- a/testcases/kernel/syscalls/setregid/setregid02.c
> +++ b/testcases/kernel/syscalls/setregid/setregid02.c
> @@ -39,7 +39,7 @@ TCID_DEFINE(setregid02);
>  
>  static gid_t neg_one = -1;
>  
> -static gid_t inval_user = (USHRT_MAX);
> +static gid_t inval_user = USHRT_MAX - 2;
>  static struct passwd *ltpuser;

Unfortunately I've found that in SLES user nobody has UID precisely
USHRT_MAX - 2 and the test fails :(

Thinking of correct solution, we probably need some
tst_get_unused_uid(). What do you think?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] setregid02: invalid user value fix

[chrubis]

Hi!
> > Unfortunately I've found that in SLES user nobody has UID precisely
> > USHRT_MAX - 2 and the test fails :(
> >
> > Thinking of correct solution, we probably need some
> > tst_get_unused_uid(). What do you think?
> >
> 
> Hi! Ok, I will do it.
> 

Do you have some estimate when will the patch be ready? I would like to
have this fix included in the release, if possible.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list