Re: [LTP] [PATCH???v3] lib/cloner.c: add function ltp_clone7 when clone supports???7 arguments

[chrubis@suse.cz]

Hi!
> > So create m4/ltp-clone7args.m4 to check whether clone support 7 arguments.
> > If HAVE_CLONE7ARGS is defined, ltp_clone7 will be defined in lib/cloner.c.
> > 
> > When tests need pass 7 arguments to clone, ltp_clone7 should be used. When
> > HAVE_CLONE7ARGS is not defined, make these tests return TCONF, like
> > clone08.
> 
> the current clone function is broken.  you cannot call va_args on an arg that
> doesn't exist.  but if the suggestions below are implemented, this shouldn't
> be a problem anymore.
> 
> > --- a/include/test.h
> > +++ b/include/test.h
> > 
> >  /* Functions from lib/cloner.c */
> >  int ltp_clone(unsigned long clone_flags, int (*fn)(void *arg), void *arg,
> > +		size_t stack_size, void *stack);
> > +#ifdef HAVE_CLONE7ARGS
> > +int ltp_clone7(unsigned long clone_flags, int (*fn)(void *arg), void *arg,
> >  		size_t stack_size, void *stack, ...);
> > +#endif
> 
> always define this prototype
> 
> > --- a/lib/cloner.c
> > +++ b/lib/cloner.c
> 
> add a helper here like:
> 
> #ifndef CLONE_SUPPORTS_7_ARGS
> # define clone(fn, stack, flags, arg, ptid, tls, ctid) clone(fn, stack, flags, arg)
> #endif
> 
> rename the existing ltp_clone to a static _ltp_clone
> 
> create a new ltp_clone that just calls _ltp_clone and passes in NULL for the
> additional 3 args
> 
> in the new ltp_clone7, have it do:
> #ifdef CLONE_SUPPORTS_7_ARGS
> 	... call _ltp_clone ...
> #else
> 	... call TCONF or TBROK or something ...
> #endif
> 
> that should keep all the test logic simple as Cyril suggested.  no need for
> them to check ifdefs, just call ltp_clone7 instead.

I will finish this one, the solution is nearly ready and I have the
means to quickly test it on most of the distros/archs.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list