Re: [LTP] [PATCH] msgctl11: process message queues by portions

[chrubis@suse.cz]

Hi!
> > Technically the idx should be named offset or off.
> >
> >> +	key_t key;
> >> +	int i, count, status;
> >> +	pid_t pid;
> >> +
> >> +	nprocs = no_of_processes;
> >
> > This is hacky, you should either pass the number as a function parameter
> > or in global variable but doing both is messy.
> >
> 
> Yes, it's.... But I need to keep nprocs global, because it's used in the 
> signal handler.

I know, there is a cleanup that depends on it.

> So I either can update nprocs before calling dotest_iteration() (right 
> in main()) or do this inside dotest_iteration().
> 
> I think that doing so inside dotest_iteration() is not an excellent 
> solution but it's compact and this choice should be pretty clear for 
> further maintenance.
> 
> What do you think?

I would prefer setting nprocs right before you call dotest_iteration(),
IMHO that way the code follows the rule of least surprise.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list