Re: [LTP] [PATCH/RFC] sigaltstack02: avoid using MINSIGSTKSZ defined by glibc

Jan Stancek
2014-02-18T09:43:14Z

----- Original Message -----
> From: "Jan Stancek" <jstancek@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Monday, 13 January, 2014 10:39:51 AM
> Subject: [LTP] [PATCH/RFC] sigaltstack02: avoid using MINSIGSTKSZ defined by glibc
>
> The value of MINSIGSTKSZ defined by glibc can be different
> as the value defined by kernel. Recent change for ppc
> is now causing sigaltstack02 to fail:
> https://sourceware.org/ml/libc-alpha/2013-08/msg00093.html
>
> Use value which is low enough for all kernel versions.
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---

Any thoughts/ideas?

Regards,
Jan

> .../kernel/syscalls/sigaltstack/sigaltstack02.c | 11 +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/sigaltstack/sigaltstack02.c
> b/testcases/kernel/syscalls/sigaltstack/sigaltstack02.c
> index d83aa1f..98c7fd3 100644
> --- a/testcases/kernel/syscalls/sigaltstack/sigaltstack02.c
> +++ b/testcases/kernel/syscalls/sigaltstack/sigaltstack02.c
> @@ -99,13 +99,12 @@ struct test_case_t { /* test case struct. to hold diff.
> test.conds */
> } Test_cases[] = {
> {
> INVAL_FLAGS, SIGSTKSZ, "Invalid Flag value", EINVAL},
> -#ifdef __ia64__
> - {
> - 0, (131027 - 1), "alternate stack is < MINSIGSTKSZ", ENOMEM},
> -#else
> + /* use value low enough for all kernel versions
> + * avoid using MINSIGSTKSZ defined by glibc as it could be different
> + * from the one in kernel ABI
> + */
> {
> - 0, (MINSIGSTKSZ - 1), "alternate stack is < MINSIGSTKSZ", ENOMEM},
> -#endif
> + 0, (2048 - 1), "alternate stack is < MINSIGSTKSZ", ENOMEM},
> {
> 0, 0, NULL, 0}
> };
> --
> 1.7.1
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.