From: chrubis@suse.cz
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] move_pages: print errno if move_pages fail
Date: Tue, 25 Feb 2014 16:29:31 +0100 [thread overview]
Message-ID: <20140225152930.GA15483@rei> (raw)
In-Reply-To: <8fcc00aaf04977590c7ffe20ce94d91b795869d8.1393341171.git.jstancek@redhat.com>
Hi!
> - TEST_ERRNO = errno;
> if (ret == -1 && errno == EPERM)
> tst_resm(TPASS, "move_pages failed with "
> "EPERM as expected");
> else
> - tst_resm(TFAIL, "move_pages did not fail "
> + tst_resm(TFAIL|TERRNO, "move_pages did not fail "
> "with EPERM");
I would consider printing value or ret too here, because we may get here
in case that the move_pages() hasn't failed at all and the errno would
be undefined in this case.
Otherwise it's fine.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-02-25 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 15:15 [LTP] [PATCH] move_pages: print errno if move_pages fail Jan Stancek
2014-02-25 15:29 ` chrubis [this message]
[not found] ` <939689770.9261934.1393346203778.JavaMail.zimbra@redhat.com>
2014-02-25 16:39 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225152930.GA15483@rei \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox