[LTP] [PATCH v2 1/3] Fix compilation errors in crasher.c

[LTP] [PATCH v2 1/3] Fix compilation errors in crasher.c

[Sweekar Pinto]

-Conditional inclusion of asm.h for kernel > 3.4
-The owner field of proc_dir_entry has been removed from
 kernel ver 2.6.30
-SPIN_LOCK_UNLOCKED is depricated. DEFINE_SPINLOCK is
 available all the way back to 2.6.12, so no need of
 conditional declaration.

Signed-off-by: Sweekar Pinto <sweekar.pinto@oracle.com>
---
 testcases/kdump/lib/crasher/crasher.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/testcases/kdump/lib/crasher/crasher.c b/testcases/kdump/lib/crasher/crasher.c
index bc192dc..fe72986 100644
--- a/testcases/kdump/lib/crasher/crasher.c
+++ b/testcases/kdump/lib/crasher/crasher.c
@@ -25,7 +25,10 @@
 #include <linux/proc_fs.h>
 #include <linux/spinlock.h>
 #include <asm/uaccess.h>
-#include <asm/system.h>
+#include <linux/version.h>
+#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 4, 0)
+# include <asm/system.h>
+#endif
 
 MODULE_LICENSE("GPL");
 
@@ -46,7 +49,7 @@ static int crasher_write(struct file *file, const char *buffer,
 			 unsigned long count, void *data)
 {
 	char value, *a;
-	spinlock_t mylock = SPIN_LOCK_UNLOCKED;
+	DEFINE_SPINLOCK(mylock);
 
 	/* grab the first byte the user gave us, ignore the rest */
 	if (copy_from_user(&value, buffer, 1))
@@ -91,10 +94,11 @@ int crasher_init(void)
 	if ((crasher_proc = create_proc_entry(CRASH, 0, NULL)) == NULL) {
 		return -ENOMEM;
 	}
-
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 30)
+	crasher_proc->owner = THIS_MODULE
+#endif
 	crasher_proc->read_proc = crasher_read;
 	crasher_proc->write_proc = crasher_write;
-	crasher_proc->owner = THIS_MODULE;
 	return 0;
 }
 
-- 
1.7.1


------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH v2 2/3] Fix passwordless ssh for network(ssh) dump test

[Sweekar Pinto]

-Force ssh to use kdump's rsa key to run commands remotely
-Some versions of kexec-tools append the date to the vmcore
 file name. So add vmcore* wildcard to the file name.

Signed-off-by: Sweekar Pinto <sweekar.pinto@oracle.com>
---
 testcases/kdump/runkdump.sh |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testcases/kdump/runkdump.sh b/testcases/kdump/runkdump.sh
index e2e681c..cd6ee1c 100755
--- a/testcases/kdump/runkdump.sh
+++ b/testcases/kdump/runkdump.sh
@@ -95,7 +95,7 @@ PrepareVerify ()
             exit 1
         fi
 
-        file=$(ssh "${SCP_PATH}" "ls -t ${COREDIR}/*/vmcore \
+        file=$(ssh -i ~/.ssh/kdump_id_rsa "${SCP_PATH}" "ls -t ${COREDIR}/*/vmcore* \
          2>/dev/null | head -1")
 
         mkdir -p "${COREDIR}/${last}"
@@ -103,7 +103,7 @@ PrepareVerify ()
         if [ "${file}" ]; then
             # Not fatal error.
             set +e
-            scp "${SCP_PATH}:${file}" "${COREDIR}/${last}"
+            scp  -i ~/.ssh/kdump_id_rsa "${SCP_PATH}:${file}" "${COREDIR}/${last}"
             set -e
         fi
 
@@ -116,7 +116,7 @@ PrepareVerify ()
         COREDIR=/mnt"${COREDIR}"
     fi
 
-    vmcore=$(ls -t "${COREDIR}"/*/vmcore 2>/dev/null | head -1)
+    vmcore=$(ls -t "${COREDIR}"/*/vmcore* 2>/dev/null | head -1)
 }
 
 VerifyTest ()
-- 
1.7.1


------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH v2 3/3] Change crashkernel param to 256M@128M

[Sweekar Pinto]

-We always get "crashkernel reservation failed -memory is in use"
 with crashkernel=64M@16M or crashkernel=128M@16M on all of our
 x86 test hardware. Here 256M@128M seems to be the best fit
 based on empirical data.

Signed-off-by: Sweekar Pinto <sweekar.pinto@oracle.com>
---
 testcases/kdump/lib/setup.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kdump/lib/setup.sh b/testcases/kdump/lib/setup.sh
index 5bc54bb..3e53f1a 100755
--- a/testcases/kdump/lib/setup.sh
+++ b/testcases/kdump/lib/setup.sh
@@ -86,11 +86,11 @@ echo "Modify Boot Loader."
 if [ "${arch}" = "ppc64" ]; then
     args="crashkernel=256M@32M xmon=off"
 elif [ "${arch}" = "i686" ]; then
-    args="crashkernel=128M@16M nmi_watchdog=1"
+    args="crashkernel=256M@128M nmi_watchdog=1"
 elif [ "${arch}" = "ia64" ]; then
     args="crashkernel=512M@256M"
 else
-    args="crashkernel=128M@16M"
+    args="crashkernel=256M@128M"
 fi
 
 if [ -x "/sbin/grubby" ]; then
-- 
1.7.1


------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v2 3/3] Change crashkernel param to 256M@128M

[chrubis]

Hi!
Pushed all three patches, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list