Re: [LTP] [PATCH v5] network: tcp_fastopen: add TCP Fast Open test

[chrubis@suse.cz]

Hi!
> >>> This version looks good. I would be happier if the shell part was ported
> >>> to the new test.sh but I can live with it as it is now.
> >>>
> >>> And this patch is blocked by the thread safety patch for the tst_res.c.
> >>> I guess I will commit it next week, it has been on the ML long enough.
> >>>
> >> OK, thanks. I can do porting later along with the fix which I would like
> >> to add to the test: there is recently added tst_get_unused_port()
> >> function, but how can I use it in the script, should I add it to
> >> tools/apicmds?
> > Yes please.
> >
> OK, so what could be the parameters for the command?
> The function takes family and type, as a result command could be as follows:
> $ tst_get_unused_port ipv4 stream
> then we need to parse strings and pass the right ones to the C function.
> 
> or we can set ids and explain the meaning in the help:
> $ tst_get_unused_port 1 0
> 
> Which one is better?

I would vote for the strings. You can easily decleare an array of
structures with string-value paris and search in these. It's not that
much of work and the shell code would be much easier to read.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list