From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v3] fcntl/fcntl31.c: add I/O availability signals test for fcntl(2)
Date: Wed, 19 Mar 2014 14:31:02 +0100 [thread overview]
Message-ID: <20140319133101.GA26802@rei> (raw)
In-Reply-To: <53292C9E.6080207@cn.fujitsu.com>
Hi!
> > You can easily fix this problem if you read the byte from pipe in the parent
> > process (before or after the wait()).
> >
> >
> > And there is a small synchronization problem too. If the write() in the
> > signal_parent() is entered before the parent sleeps in sigtimedwait() the
> > signal is lost and the test fails.
> >
> > What we need to do is to ensure parents sleeps in sigtimedwait() before we
> > execute the write(). I guess that TST_PROCESS_STATE_WAIT() in child should work
> > here.
>
> Thanks for pointing these two issues.
> My test work is not that complete, sorry.
Getting things right at first try is hard and everybody does mistakes...
Just keep up the good work you do ;).
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-03-19 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 8:45 [LTP] [PATCH v3] fcntl/fcntl31.c: add I/O availability signals test for fcntl(2) Xiaoguang Wang
2014-03-17 18:00 ` chrubis
[not found] ` <53292C9E.6080207@cn.fujitsu.com>
2014-03-19 13:31 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319133101.GA26802@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox