From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WVNtC-0004jg-GL for ltp-list@lists.sourceforge.net; Wed, 02 Apr 2014 16:19:46 +0000 Date: Wed, 2 Apr 2014 18:19:04 +0200 From: chrubis@suse.cz Message-ID: <20140402161904.GA30505@rei.Home> References: <1395730866-28862-1-git-send-email-alexey.kodanev@oracle.com> <20140402145301.GA16032@rei.Home> <533C2D8A.4080502@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <533C2D8A.4080502@oracle.com> Subject: Re: [LTP] [PATCH v2] lib/test_net.sh: add network help script List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Alexey Kodanev Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net Hi! > >> +[ -z "$TST_LIB_LOADED" ] && . test.sh > >> + > >> +# Run command on remote host. > >> +# Options: > >> +# -b run in background > >> +# -s safe option, if something goes wrong, will exit with TBROK > >> +# -c specify command to run > >> + > >> +tst_rhost_run() > >> +{ > >> + # this is needed to run tools/apicmds on remote host > >> + local pre_cmd="TCID=$TCID TST_COUNT=1 TST_TOTAL=1" > > Hmm, if I get it right, this is here in order to make possible to run > > the tst_get_unused_port apicmd command. > > > > I don't like that much that we have to set the TST_COUNT and TST_TOTAL > > too. Maybe we should relax the rules in ltpapicmd.c, given that > > TST_TOTAL is not used for anything in the lib/ directory and the > > tst_count is used only used only in the tst_print(). > Yes, you are right, I did so because of apicmds. > What about if we remove the check completely? We won't use tst_res*, > tst_brk*... in new tests. For now I've added an exception for the tst_get_unused_port the same way we do it for tst_kvercmp. See latest git commit. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list