From: chrubis@suse.cz
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 2/3] rpc01: moved common functions to a lib
Date: Mon, 7 Apr 2014 20:12:36 +0200 [thread overview]
Message-ID: <20140407181236.GA8332@rei> (raw)
In-Reply-To: <1387812348-23017-2-git-send-email-stanislav.kholmanskikh@oracle.com>
Hi!
> diff --git a/testcases/network/rpc/basic_tests/rpc01/Makefile b/testcases/network/rpc/basic_tests/rpc01/Makefile
> index 732d816..68ea85e 100644
> --- a/testcases/network/rpc/basic_tests/rpc01/Makefile
> +++ b/testcases/network/rpc/basic_tests/rpc01/Makefile
> @@ -28,7 +28,15 @@ include $(top_srcdir)/include/mk/env_pre.mk
> CPPFLAGS += -Wno-error
>
> INSTALL_TARGETS := rpc01
> -
> SUBDIRS := datafiles
>
> +LIBSRCS := $(abs_srcdir)/librpc01.c
> +INTERNAL_LIB := librpc01.a
> +LDFLAGS += -L$(abs_srcdir)
> +LDLIBS += -lrpc01
> +
> +MAKE_TARGETS := rpc1 rpc_server
> +$(MAKE_TARGETS): $(INTERNAL_LIB)
> +
> include $(top_srcdir)/include/mk/generic_trunk_target.mk
> +include $(top_srcdir)/include/mk/lib.mk
There is a problem with this change. Including both trunk target and lib
makes the install phase to install the MAKE_TARGETS both to
/testcases/bin and /usr/lib{,64}/ (because each of them installs
MAKE_TARGETS to INSTALL_DIR).
Given that there may be other problems with this setup I would rather
move the library to a subdirectory with it's own Makefile. What do you
think?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-04-07 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 15:25 [LTP] [PATCH 1/3] runtest/stress.part3: fix cmd for the rpc01 test case Stanislav Kholmanskikh
2013-12-23 15:25 ` [LTP] [PATCH 2/3] rpc01: moved common functions to a lib Stanislav Kholmanskikh
2013-12-23 15:25 ` [LTP] [PATCH 3/3] rpc01: fix compile-time warnings Stanislav Kholmanskikh
2014-02-05 12:08 ` chrubis
2014-04-07 18:12 ` chrubis [this message]
[not found] ` <5343A0AC.6010803@oracle.com>
2014-04-08 7:12 ` [LTP] [PATCH] rpc01: moved the library into a separate directory Stanislav Kholmanskikh
2014-04-08 11:41 ` chrubis
2014-04-08 9:56 ` [LTP] [PATCH 2/3] rpc01: moved common functions to a lib chrubis
2014-02-05 10:45 ` [LTP] [PATCH 1/3] runtest/stress.part3: fix cmd for the rpc01 test case Stanislav Kholmanskikh
2014-02-05 12:10 ` chrubis
2014-02-05 12:11 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407181236.GA8332@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox