From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v3] testscripts/test_robind.sh: cleanup and make some fixes
Date: Tue, 8 Apr 2014 21:15:25 +0200 [thread overview]
Message-ID: <20140408191525.GA8069@rei> (raw)
In-Reply-To: <20140408182052.GA5854@rei>
Hi!
> I've fixed the script to be POSIX shell compatible (see diff below) and added a
> followup patch to move the test_robind.sh script to
> testcases/kernel/fs/fs_readonly because the runtest file does not work when
> it's in testscripts directory which is not in $PATH.
And also moved the cleanup definition after the tst_tmpdir because
otherwise you get an error if some of the checks before tst_tmpdir
fails. We may also add the cleanup to ctrl+c trap.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-04-08 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 10:28 [LTP] [PATCH v3] testscripts/test_robind.sh: cleanup and make some fixes Xiaoguang Wang
2014-04-08 18:20 ` chrubis
2014-04-08 19:15 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408191525.GA8069@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox