[LTP] [PATCH] containers/netns:parameters are not correct when calling crtchild() function

[LTP] [PATCH] containers/netns:parameters are not correct when calling crtchild() function

[shuang.qiu]

From: Shuang Qiu <shuang.qiu@oracle.com>

The numbers of parameters for crtchild() function which called in
two_children_ns.c and par_chld_ipv6.c is not correct.And it will make
the child process to be a zombie process.

Signed-off-by: Shuang Qiu <shuang.qiu@oracle.com>
---
 testcases/kernel/containers/netns/par_chld_ipv6.c  |    4 ++--
 .../kernel/containers/netns/two_children_ns.c      |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/containers/netns/par_chld_ipv6.c b/testcases/kernel/containers/netns/par_chld_ipv6.c
index f0d17ba..68c671f 100644
--- a/testcases/kernel/containers/netns/par_chld_ipv6.c
+++ b/testcases/kernel/containers/netns/par_chld_ipv6.c
@@ -45,7 +45,7 @@
 #include "test.h"
 #include "config.h"
 
-extern int crtchild(char *);
+extern int crtchild(char *, char *);
 
 char *TCID = "netns_ipv6";
 int TST_TOTAL = 1;
@@ -95,7 +95,7 @@ int main()
 #else
 		tst_resm(TCONF, "System doesn't have unshare support");
 #endif
-		return crtchild(child);
+		return crtchild(child, NULL);
 	} else {
 
 		//parent
diff --git a/testcases/kernel/containers/netns/two_children_ns.c b/testcases/kernel/containers/netns/two_children_ns.c
index 235d9c4..4d7808c 100644
--- a/testcases/kernel/containers/netns/two_children_ns.c
+++ b/testcases/kernel/containers/netns/two_children_ns.c
@@ -47,7 +47,7 @@
 #include "libclone.h"
 #include "config.h"
 
-extern int crtchild(char *);
+extern int crtchild(char *, char *);
 
 char *TCID = "netns_2children";
 int TST_TOTAL = 1;
@@ -109,7 +109,7 @@ int main()
 				return ret;
 			}
 #endif
-			return crtchild(child[i]);
+			return crtchild(child[i], NULL);
 		} else {
 			//Parent
 
-- 
1.7.7


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] containers/netns:parameters are not correct when calling crtchild() function

[chrubis]

Hi!
> The numbers of parameters for crtchild() function which called in
> two_children_ns.c and par_chld_ipv6.c is not correct.And it will make
> the child process to be a zombie process.

Can you please create proper header file (common.h) and move the
function prototype there and include it in both common.c and the tests
that use it?

Because otherwise the code may break again if sommebody forgets to
change all occurences.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list