Re: [LTP] [PATCH] fix fanotify syscall check on compat kernel

chrubis
2014-04-17T13:28:37Z

Hi!
> > Also I've been unable to make the testcases work with -m32 on x86_64
> > both with and without the patch and even when using glibc wrappers from
> > sys/fallocate.h, in all cases the error is EINVAL which suggets that the
> > parameters are passed wrongly somewhere on the way.
>
> Does it work on the same kernel with -m64 ?
> In any case, for the tests to work the kernel needs to have been compiled with the
> kernel option CONFIG_FANOTIFY_ACCESS_PERMISSIONS set. In my initial tests this
> option wasn't set and I got EINVAL too.

And it seems to work (-m32 with your patch) on two testing machines with
slightly older kernel. So I guess that the patch is fine and I had just
bad luck with one particular machine.