From: chrubis@suse.cz
To: Helge Deller <deller@gmx.de>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] fix fanotify syscall check on compat kernel
Date: Thu, 17 Apr 2014 18:57:06 +0200 [thread overview]
Message-ID: <20140417165706.GA2833@rei> (raw)
In-Reply-To: <20140416190028.GA2093@ls3530.fritz.box>
Hi!
> The fanotify[0-5] testcases use the myfanotify_mark() wrapper for the
> fanotify_mark() syscall. But the #define does not take into account, that
> the mask field is actually of type _u64 where we need to split the hi
> and low word in the syscall on a 32bit arch.
>
> The attached patch converts the #define to a inline function where
> the compiler will help to convert the given values to the correct types
> (e.g. unsigned long).
>
> Bug found and tested on the parisc/hppa (32bit userspace with 64bit
> kernel) arch.
I've pushed slightly modified version of this patch. Please check that
it works fine for you.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-04-17 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 19:00 [LTP] [PATCH] fix fanotify syscall check on compat kernel Helge Deller
2014-04-17 9:33 ` chrubis
[not found] ` <trinity-7fc052ce-4544-4fa4-afc0-9b68430ef693-1397729289569@3capp-gmx-bs62>
2014-04-17 10:16 ` chrubis
2014-04-17 13:27 ` chrubis
2014-04-17 15:00 ` chrubis
2014-04-17 16:57 ` chrubis [this message]
[not found] ` <5350E02B.7080104@gmx.de>
[not found] ` <20140418082553.GA3389@ls3530.fritz.box>
2014-04-22 11:57 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417165706.GA2833@rei \
--to=chrubis@suse.cz \
--cc=deller@gmx.de \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox