From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] configure: add configure check for GCC -Wold-style-definition
Date: Fri, 18 Apr 2014 11:43:28 +0200 [thread overview]
Message-ID: <20140418094328.GA11147@rei> (raw)
In-Reply-To: <3992309.8rLpXb3keE@vapier>
Hi!
> On Fri 11 Apr 2014 13:26:59 Alexey Kodanev wrote:
> > +backup_cflags="$CFLAGS"
> > +CFLAGS="-Wold-style-definition"
>
> this isn't really safe. the CFLAGS might have critical settings in there that
> impact linking. why not just append ?
We can also change the AC_LINK_IFELSE() to AC_COMPILE_IFELSE().
Given this is not critical (the worst case is that old style warnings
are not enabled) this could wait after the release.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-04-18 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 9:26 [LTP] [PATCH] configure: add configure check for GCC -Wold-style-definition Alexey Kodanev
2014-04-14 14:27 ` chrubis
2014-04-17 19:37 ` Mike Frysinger
2014-04-18 9:43 ` chrubis [this message]
2014-04-23 15:43 ` chrubis
2014-05-15 13:25 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418094328.GA11147@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox