public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] OpenPosix timeout fixes
@ 2014-04-21 11:07 Stanislav Kholmanskikh
  2014-04-21 11:07 ` [LTP] [PATCH 1/2] pitest-2, pitest-3: increased the timeout Stanislav Kholmanskikh
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-04-21 11:07 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

Hi!

We intentionally compile this suite without any optimizations.

On some non-x86 platforms the test cases may execute longer that it's expected.

Perhaps, the timeout values were initially set for x86 environment.

Given that OpenPosix Test Suite is not a benchmark, I see no problem in increasing
the values a bit...

Thanks.


------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [LTP] [PATCH 1/2] pitest-2, pitest-3: increased the timeout
  2014-04-21 11:07 [LTP] OpenPosix timeout fixes Stanislav Kholmanskikh
@ 2014-04-21 11:07 ` Stanislav Kholmanskikh
  2014-04-21 11:07 ` [LTP] [PATCH 2/2] open_posix_testsuite: increased timeout to 5 min Stanislav Kholmanskikh
  2014-04-22 11:56 ` [LTP] OpenPosix timeout fixes Jan Stancek
  2 siblings, 0 replies; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-04-21 11:07 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

On some platforms do_work_dummy() (if compiled without any optimizations,
and it's by default) executes longer than the specified timeout of 100 ms.

Therefore there is a very small chance that TL may lock the mutex during
sleep() in the main thread, and most of the time the tests will fail with:
../../../functional/threads/pi_test/pitest-2.c: 222: FAIL: Thread TB1: lock returned 0 Success, slept 0.000008

To overcome this I increased the timeout value for TBs. It doesn't break the logic.

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 .../functional/threads/pi_test/pitest-2.c          |    4 ++--
 .../functional/threads/pi_test/pitest-3.c          |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-2.c b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-2.c
index ee810eb..dda51c3 100644
--- a/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-2.c
+++ b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-2.c
@@ -67,8 +67,8 @@ struct thread_param {
 } tp[] = {
 	{
 	0, 0, 0, 1, SCHED_FIFO, "TL", 0, 0, 0, 0}, {
-	1, 0, 100, 2, SCHED_FIFO, "TP1", 0, 0, 0, 0}, {
-	2, 0, 100, 5, SCHED_FIFO, "TP2", 0, 0, 0, 0}, {
+	1, 0, 500, 2, SCHED_FIFO, "TP1", 0, 0, 0, 0}, {
+	2, 0, 500, 5, SCHED_FIFO, "TP2", 0, 0, 0, 0}, {
 	3, 0, 0, 3, SCHED_FIFO, "TF", 1, 0, 0, 0}, {
 	4, 0, 0, 3, SCHED_FIFO, "TF", 2, 0, 0, 0}, {
 	5, 0, 0, 3, SCHED_FIFO, "TF", 3, 0, 0, 0}, {
diff --git a/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-3.c b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-3.c
index e0438d6..5e925a5 100644
--- a/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-3.c
+++ b/testcases/open_posix_testsuite/functional/threads/pi_test/pitest-3.c
@@ -68,8 +68,8 @@ struct thread_param {
 } tp[] = {
 	{
 	0, 0, 0, 1, SCHED_FIFO, "TL", 0, 0, 0, 0}, {
-	1, 0, 100, 2, SCHED_FIFO, "TP1", 0, 0, 0, 0}, {
-	1, 0, 100, 5, SCHED_FIFO, "TP2", 0, 0, 0, 0}, {
+	1, 0, 500, 2, SCHED_FIFO, "TP1", 0, 0, 0, 0}, {
+	1, 0, 500, 5, SCHED_FIFO, "TP2", 0, 0, 0, 0}, {
 	2, 0, 0, 3, SCHED_FIFO, "TF", 1, 0, 0, 0}, {
 	3, 0, 0, 3, SCHED_FIFO, "TF", 2, 0, 0, 0}, {
 	4, 0, 0, 3, SCHED_FIFO, "TF", 3, 0, 0, 0}, {
-- 
1.7.1


------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [LTP] [PATCH 2/2] open_posix_testsuite: increased timeout to 5 min
  2014-04-21 11:07 [LTP] OpenPosix timeout fixes Stanislav Kholmanskikh
  2014-04-21 11:07 ` [LTP] [PATCH 1/2] pitest-2, pitest-3: increased the timeout Stanislav Kholmanskikh
@ 2014-04-21 11:07 ` Stanislav Kholmanskikh
  2014-04-22 11:56 ` [LTP] OpenPosix timeout fixes Jan Stancek
  2 siblings, 0 replies; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-04-21 11:07 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

To make some tests complete in time on some non-x86 systems (especially
pthread_create-1_6).

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 testcases/open_posix_testsuite/bin/run-tests.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/open_posix_testsuite/bin/run-tests.sh b/testcases/open_posix_testsuite/bin/run-tests.sh
index bd8ca14..6737f83 100755
--- a/testcases/open_posix_testsuite/bin/run-tests.sh
+++ b/testcases/open_posix_testsuite/bin/run-tests.sh
@@ -113,7 +113,7 @@ if [ ! -f "$T0_VAL" ]; then
 fi
 if TIMEOUT_RET=$(cat "$T0_VAL"); then
 
-	TIMEOUT_VAL=${TIMEOUT_VAL:=240}
+	TIMEOUT_VAL=${TIMEOUT_VAL:=300}
 	if [ -f test_defs ] ; then
 		. ./test_defs || exit $?
 	fi
-- 
1.7.1


------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [LTP] OpenPosix timeout fixes
  2014-04-21 11:07 [LTP] OpenPosix timeout fixes Stanislav Kholmanskikh
  2014-04-21 11:07 ` [LTP] [PATCH 1/2] pitest-2, pitest-3: increased the timeout Stanislav Kholmanskikh
  2014-04-21 11:07 ` [LTP] [PATCH 2/2] open_posix_testsuite: increased timeout to 5 min Stanislav Kholmanskikh
@ 2014-04-22 11:56 ` Jan Stancek
  2014-04-22 12:08   ` chrubis
  2 siblings, 1 reply; 5+ messages in thread
From: Jan Stancek @ 2014-04-22 11:56 UTC (permalink / raw)
  To: Stanislav Kholmanskikh; +Cc: vasily isaenko, ltp-list





----- Original Message -----
> From: "Stanislav Kholmanskikh" <stanislav.kholmanskikh@oracle.com>
> To: ltp-list@lists.sourceforge.net
> Cc: "vasily isaenko" <vasily.isaenko@oracle.com>
> Sent: Monday, 21 April, 2014 1:07:39 PM
> Subject: [LTP] OpenPosix timeout fixes
> 
> Hi!
> 
> We intentionally compile this suite without any optimizations.
> 
> On some non-x86 platforms the test cases may execute longer that it's
> expected.
> 
> Perhaps, the timeout values were initially set for x86 environment.
> 
> Given that OpenPosix Test Suite is not a benchmark, I see no problem in
> increasing
> the values a bit...

Me neither, ACK.

Regards,
Jan

> 
> Thanks.
> 
> 
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] OpenPosix timeout fixes
  2014-04-22 11:56 ` [LTP] OpenPosix timeout fixes Jan Stancek
@ 2014-04-22 12:08   ` chrubis
  0 siblings, 0 replies; 5+ messages in thread
From: chrubis @ 2014-04-22 12:08 UTC (permalink / raw)
  To: Jan Stancek; +Cc: vasily isaenko, ltp-list

Hi!
> Me neither, ACK.

Acked as well.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-04-22 12:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-21 11:07 [LTP] OpenPosix timeout fixes Stanislav Kholmanskikh
2014-04-21 11:07 ` [LTP] [PATCH 1/2] pitest-2, pitest-3: increased the timeout Stanislav Kholmanskikh
2014-04-21 11:07 ` [LTP] [PATCH 2/2] open_posix_testsuite: increased timeout to 5 min Stanislav Kholmanskikh
2014-04-22 11:56 ` [LTP] OpenPosix timeout fixes Jan Stancek
2014-04-22 12:08   ` chrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox