From: chrubis@suse.cz
To: Shuang Qiu <shuang.qiu@oracle.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v3] containers/netns:parameters are not correct when calling, crtchild() function
Date: Tue, 22 Apr 2014 14:20:41 +0200 [thread overview]
Message-ID: <20140422122041.GB3951@rei> (raw)
In-Reply-To: <53510E46.4090907@oracle.com>
Hi!
> The numbers of parameters for crtchild() function which called in
> two_children_ns.c and par_chld_ipv6.c is not correct.And it will make
> the child process to be a zombie process.
> And also move the definition of the function to the header file(common.h)
> +#ifndef _COMMON_H_
> +#define _COMMON_H_
Identifiers starting with double underscore or with underscore and
capital letter are reserved for glibc implementation. We should use
something as COMMON_H or COMMON_H__ to be sure not to collide. But this
is very minor.
Apart from this the patch has been corrupted, most likely line wrapped
by your mail client. Have a look at:
https://www.kernel.org/doc/Documentation/email-clients.txt
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-04-22 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 9:40 [LTP] [PATCH v2] containers/netns:parameters are not correct when calling, crtchild() function Shuang Qiu
2014-04-17 12:50 ` chrubis
2014-04-18 11:36 ` [LTP] [PATCH v3] " Shuang Qiu
2014-04-22 12:20 ` chrubis [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-23 5:24 shuang.qiu
2014-04-23 14:24 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422122041.GB3951@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=shuang.qiu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox