From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 1/2] runltp: fix errors when using getenv(3) to get environment variable LTP_BIG_DEV or LTP_BIG_DEV_FS_TYPE
Date: Tue, 22 Apr 2014 15:59:09 +0200 [thread overview]
Message-ID: <20140422135909.GE3951@rei> (raw)
In-Reply-To: <1397561602-18935-1-git-send-email-wangxg.fnst@cn.fujitsu.com>
Hi!
> Make runltp export LTP_BIG_DEV and LTP_BIG_DEV_FS_TYPE only when they have a non-zero
> value. We do this to make getenv("LTP_BIG_DEV") or getenv("LTP_BIG_DEV_FS_TYPE")
> return NULL, if user does not specify a big block device. Because users usually write
> such code:
> device = getenv("LTP_BIG_DEV");
> if (device == NULL) {
> tst_brkm(TCONF, NULL,
> "you must specify a big blockdevice(>1.2G)");
> } else {
> tst_mkfs(NULL, device, "ext3", NULL);
> }
I've shortened the first line of the commit description a bit and
pushed the patch, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-04-22 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 11:33 [LTP] [PATCH 1/2] runltp: fix errors when using getenv(3) to get environment variable LTP_BIG_DEV or LTP_BIG_DEV_FS_TYPE Xiaoguang Wang
2014-04-15 11:33 ` [LTP] [PATCH 2/2] syscalls/rename/rename11.c: add ELOOP, EMLINK and EROFS error value tests Xiaoguang Wang
2014-05-19 16:29 ` chrubis
[not found] ` <537B4259.2010200@cn.fujitsu.com>
2014-05-20 12:24 ` chrubis
2014-04-22 13:59 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422135909.GE3951@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox