[LTP] [PATCH 1/2] runltp: fix errors when using getenv(3) to get environment variable LTP_BIG_DEV or LTP_BIG_DEV_FS_TYPE

[LTP] [PATCH 1/2] runltp: fix errors when using getenv(3) to get environment variable LTP_BIG_DEV or LTP_BIG_DEV_FS_TYPE

[Xiaoguang Wang]

Make runltp export LTP_BIG_DEV and LTP_BIG_DEV_FS_TYPE only when they have a non-zero
value. We do this to make getenv("LTP_BIG_DEV") or getenv("LTP_BIG_DEV_FS_TYPE")
return NULL, if user does not specify a big block device. Because users usually write
such code:
	device = getenv("LTP_BIG_DEV");
	if (device == NULL) {
		tst_brkm(TCONF, NULL,
			 "you must specify a big blockdevice(>1.2G)");
	} else {
		tst_mkfs(NULL, device, "ext3", NULL);
	}

Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
---
 runltp | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/runltp b/runltp
index 9cb5fe8..ea328f0 100755
--- a/runltp
+++ b/runltp
@@ -81,9 +81,7 @@ setup()
     export PATH="${PATH}:${LTPROOT}/testcases/bin"
 
     export LTP_DEV=""
-    export LTP_BIG_DEV=""
     export LTP_DEV_FS_TYPE="ext2"
-    export LTP_BIG_DEV_FS_TYPE="ext2"
 
     [ -d "$LTPROOT/testcases/bin" ] ||
     {
@@ -433,7 +431,7 @@ main()
         b) DEVICE=$OPTARG;;
         B) LTP_DEV_FS_TYPE=$OPTARG;;
         z) BIG_DEVICE=$OPTARG;;
-        Z) LTP_BIG_DEV_FS_TYPE=$OPTARG;;
+        Z) BIG_DEVICE_FS_TYPE=$OPTARG;;
         \?) usage;;
         esac
     done
@@ -696,7 +694,12 @@ main()
         echo "Tests which require a big block device are disabled."
         echo "You can specify it with option -z"
     else
-        LTP_BIG_DEV=$BIG_DEVICE
+        export LTP_BIG_DEV=$BIG_DEVICE
+        if [ -z "$BIG_DEVICE_FS_TYPE" ];then
+            export LTP_BIG_DEV_FS_TYPE="ext2"
+        else
+            export LTP_BIG_DEV_FS_TYPE=$BIG_DEVICE_FS_TYPE
+        fi
     fi
 
     if [ $RUN_REPEATED -gt 1 ]; then # You need to specify at least more than 1 sequential run, else it runs default
-- 
1.8.2.1


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 2/2] syscalls/rename/rename11.c: add ELOOP, EMLINK and EROFS error value tests

[Xiaoguang Wang]

Note: int rename(const char *old, const char *new);
For EMLINK error value test: the file named by old is a directory and the
link count of the parent directory of new would exceed {LINK_MAX}.

This test will work on ext2 and ext3 filesystem. But there is some difference in some
linux distributions.

For example, in fedora19 and RHEL7.0Beta, the kernel configs for ext2/ext3/ext4 filesystems
list below:
# CONFIG_EXT2_FS is not set
# CONFIG_EXT3_FS is not set
CONFIG_EXT4_FS=m
CONFIG_EXT4_USE_FOR_EXT23=y
CONFIG_EXT4_FS_POSIX_ACL=y
CONFIG_EXT4_FS_SECURITY=y

If kernel has the above config, ext2 or ext3 is disabled. Then when we mount ext2 or
ext3 filesystem, the ext4 filesystem driver code will be used for ext2 or ext3 file
system mounts. This allows users to reduce their compiled kernel size by using one
file system driver for ext2, ext3, and ext4 file systems. That means though we mount
a block device with ext2 filesystem in it, the kernel will possibely use ext4 driver
code instead.

So for this EMLINK error value test, we have test in ext4 directly. But the max
subdirectories(per directory) in ext4 is unlimited default(When the link count exceeds
65,000, it is reset to 1 and no longer increases.). But EMLINK error value test
need the directory have a valid LINK_MAX, so for ext4, we use mkfs to clear "dir_index"
filesystem feature, then ext4 has a LINK_MAX:65000:
	mkfs.ext4 -O ^dir_index device

And we also need a big block device to have tests, the default provided by runltp
is 20MB, which is not big enough to hold more than 65000 directories.

Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
---
 runtest/ltplite                             |   1 +
 runtest/stress.part3                        |   1 +
 runtest/syscalls                            |   1 +
 testcases/kernel/syscalls/.gitignore        |   1 +
 testcases/kernel/syscalls/rename/rename11.c | 220 ++++++++++++++++++++++++++++
 5 files changed, 224 insertions(+)
 create mode 100644 testcases/kernel/syscalls/rename/rename11.c

diff --git a/runtest/ltplite b/runtest/ltplite
index ebe171e..7587d24 100644
--- a/runtest/ltplite
+++ b/runtest/ltplite
@@ -641,6 +641,7 @@ rename07 rename07
 rename08 rename08
 rename09 rename09
 rename10 rename10
+rename11 rename11
 rename12 rename12
 rename13 rename13
 rename14 rename14
diff --git a/runtest/stress.part3 b/runtest/stress.part3
index b21e44b..bbef859 100644
--- a/runtest/stress.part3
+++ b/runtest/stress.part3
@@ -551,6 +551,7 @@ rename07 rename07
 rename08 rename08
 rename09 rename09
 rename10 rename10
+rename11 rename11
 rename12 rename12
 rename13 rename13
 rename14 rename14
diff --git a/runtest/syscalls b/runtest/syscalls
index fb3e59f..098b92d 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -845,6 +845,7 @@ rename07 rename07
 rename08 rename08
 rename09 rename09
 rename10 rename10
+rename11 rename11
 rename12 rename12
 rename13 rename13
 rename14 rename14
diff --git a/testcases/kernel/syscalls/.gitignore b/testcases/kernel/syscalls/.gitignore
index d5c7bac..5abcb15 100644
--- a/testcases/kernel/syscalls/.gitignore
+++ b/testcases/kernel/syscalls/.gitignore
@@ -688,6 +688,7 @@
 /rename/rename08
 /rename/rename09
 /rename/rename10
+/rename/rename11
 /rename/rename12
 /rename/rename13
 /rename/rename14
diff --git a/testcases/kernel/syscalls/rename/rename11.c b/testcases/kernel/syscalls/rename/rename11.c
new file mode 100644
index 0000000..a211464
--- /dev/null
+++ b/testcases/kernel/syscalls/rename/rename11.c
@@ -0,0 +1,220 @@
+/*
+ * Copyright (c) 2014 Fujitsu Ltd.
+ * Author: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
+ *
+ * This program is free software;  you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY;  without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
+ * the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program;  if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+/*
+ * Test Description:
+ *  Verify that,
+ *   1. rename() fails with -1 return value and sets errno to ELOOP, if too
+ *      many symbolic links were encountered in resolving oldpath or newpath.
+ *   2. rename() fails with -1 return value and sets errno to EROFS,
+ *      if the file is on a read-only file system.
+ *   3. rename() fails with -1 return value and sets errno to EMLINK,
+ *   	if the file named by old is a directory and the link count of
+ *   	the parent directory of new would exceed {LINK_MAX}.
+ *
+ */
+
+#include <stdio.h>
+#include <errno.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <sys/mount.h>
+
+#include "test.h"
+#include "usctest.h"
+#include "safe_macros.h"
+
+#define MNTPOINT	"mntpoint"
+#define TEST_EROFS	"mntpoint/test_erofs"
+#define TEST_NEW_EROFS	"mntpoint/new_test_erofs"
+
+#define TEST_EMLINK	"mntpoint/test_emlink"
+#define TEST_NEW_EMLINK	"mntpoint/test_parent_dir/test_emlink"
+
+#define TEST_NEW_ELOOP	"new_test_eloop"
+#define ELOPFILE	"/test_eloop"
+static char elooppathname[sizeof(ELOPFILE) * 43] = ".";
+
+static char *device;
+static int mount_flag;
+
+static void cleanup(void);
+static void setup(void);
+
+char *TCID = "rename11";
+
+static int exp_enos[] = { ELOOP, EROFS, EMLINK, 0 };
+
+static void test_eloop(void);
+static void test_erofs(void);
+static void test_emlink(void);
+
+static void (*testfunc[])(void) = { test_eloop, test_erofs, test_emlink };
+
+int TST_TOTAL = ARRAY_SIZE(testfunc);
+
+int main(int ac, char **av)
+{
+	int lc, i;
+	char *msg;
+
+	msg = parse_opts(ac, av, NULL, NULL);
+	if (msg != NULL)
+		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
+
+	setup();
+
+	for (lc = 0; TEST_LOOPING(lc); lc++) {
+		tst_count = 0;
+
+		for (i = 0; i < TST_TOTAL; i++)
+			(*testfunc[i])();
+	}
+
+	cleanup();
+	tst_exit();
+}
+
+static void setup(void)
+{
+	int i, ret;
+	unsigned long long link_max = 0;
+	char lname[PATH_MAX];
+	const char *const opts[] = { "-O", "^dir_index", NULL };
+
+	tst_sig(NOFORK, DEF_HANDLER, cleanup);
+	tst_require_root(NULL);
+
+	device = getenv("LTP_BIG_DEV");
+	if (device == NULL) {
+		tst_brkm(TCONF, NULL,
+			 "you must specify a big blockdevice(>500MB)");
+	} else {
+		tst_mkfs(NULL, device, "ext4", opts);
+	}
+
+	tst_tmpdir();
+	TEST_EXP_ENOS(exp_enos);
+	TEST_PAUSE;
+
+	SAFE_MKDIR(cleanup, MNTPOINT, 0755);
+	/* we have tests in ext4 */
+	if (mount(device, MNTPOINT, "ext4", 0, NULL) < 0) {
+		tst_brkm(TBROK | TERRNO, cleanup,
+			 "mount device:%s failed", device);
+	}
+	mount_flag = 1;
+
+	SAFE_TOUCH(cleanup, TEST_EROFS, 0644, NULL);
+
+	SAFE_MKDIR(cleanup, TEST_EMLINK, 0755);
+	SAFE_MKDIR(cleanup, "mntpoint/test_parent_dir", 0755);
+	while (1) {
+		sprintf(lname, "mntpoint/test_parent_dir/test%lld", ++link_max);
+		ret = mkdir(lname, 0755);
+		if (ret == -1) {
+			switch (errno) {
+			case EMLINK:
+				tst_resm(TINFO, "for ext4 the max links is"
+					" %lld", link_max + 1);
+				break;
+			default:
+				tst_brkm(TCONF | TERRNO, cleanup,
+					 "we do not hit the maximum number of "
+					 "links to dir test_parent_dir in ext4."
+					 "Unexpected error:");
+				break;
+			}
+			break;
+		}
+	}
+
+	/*
+	 * NOTE: the ELOOP test is written based on that the consecutive
+	 * symlinks limits in kernel is hardwired to 40.
+	 */
+	SAFE_MKDIR(cleanup, "test_eloop", 0644);
+	SAFE_SYMLINK(cleanup, "../test_eloop", "test_eloop/test_eloop");
+	for (i = 0; i < 43; i++)
+		strcat(elooppathname, ELOPFILE);
+}
+
+static void check_and_print(int expected_errno)
+{
+	if (TEST_RETURN == -1) {
+		if (TEST_ERRNO == expected_errno) {
+			tst_resm(TPASS | TTERRNO, "failed as expected");
+		} else {
+			tst_resm(TFAIL | TTERRNO,
+				 "failed unexpectedly; expected - %d : %s",
+				 expected_errno, strerror(expected_errno));
+		}
+	} else {
+		tst_resm(TFAIL, "rename succeeded unexpectedly");
+	}
+}
+
+static void test_eloop(void)
+{
+	TEST(rename(elooppathname, TEST_NEW_ELOOP));
+	check_and_print(ELOOP);
+
+	if (TEST_RETURN == 0)
+		SAFE_UNLINK(cleanup, TEST_NEW_ELOOP);
+}
+
+static void test_erofs(void)
+{
+	if (mount(device, MNTPOINT, "ext4", MS_REMOUNT |
+	    MS_RDONLY, NULL) < 0) {
+		tst_brkm(TBROK | TERRNO, cleanup,
+			 "remount device:%s failed", device);
+	}
+
+	TEST(rename(TEST_EROFS, TEST_NEW_EROFS));
+	check_and_print(EROFS);
+
+	if (TEST_RETURN == 0)
+		SAFE_UNLINK(cleanup, TEST_NEW_EROFS);
+
+	if (mount(device, MNTPOINT, "ext4", MS_REMOUNT, NULL) < 0) {
+		tst_brkm(TBROK | TERRNO, cleanup,
+			 "remount device:%s failed", device);
+	}
+}
+
+static void test_emlink(void)
+{
+	TEST(rename(TEST_EMLINK, TEST_NEW_EMLINK));
+	check_and_print(EMLINK);
+
+	if (TEST_RETURN == 0)
+		SAFE_UNLINK(cleanup, TEST_NEW_EMLINK);
+}
+
+static void cleanup(void)
+{
+	TEST_CLEANUP;
+
+	if (mount_flag && umount(MNTPOINT) < 0)
+		tst_resm(TWARN | TERRNO, "umount device:%s failed", device);
+
+	tst_rmdir();
+}
-- 
1.8.2.1


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] syscalls/rename/rename11.c: add ELOOP, EMLINK and EROFS error value tests

[chrubis]

Hi!
> Note: int rename(const char *old, const char *new);
> For EMLINK error value test: the file named by old is a directory and the
> link count of the parent directory of new would exceed {LINK_MAX}.
> 
> This test will work on ext2 and ext3 filesystem. But there is some difference in some
> linux distributions.
> 
> For example, in fedora19 and RHEL7.0Beta, the kernel configs for ext2/ext3/ext4 filesystems
> list below:
> # CONFIG_EXT2_FS is not set
> # CONFIG_EXT3_FS is not set
> CONFIG_EXT4_FS=m
> CONFIG_EXT4_USE_FOR_EXT23=y
> CONFIG_EXT4_FS_POSIX_ACL=y
> CONFIG_EXT4_FS_SECURITY=y
> 
> If kernel has the above config, ext2 or ext3 is disabled. Then when we mount ext2 or
> ext3 filesystem, the ext4 filesystem driver code will be used for ext2 or ext3 file
> system mounts. This allows users to reduce their compiled kernel size by using one
> file system driver for ext2, ext3, and ext4 file systems. That means though we mount
> a block device with ext2 filesystem in it, the kernel will possibely use ext4 driver
> code instead.
> 
> So for this EMLINK error value test, we have test in ext4 directly. But the max
> subdirectories(per directory) in ext4 is unlimited default(When the link count exceeds
> 65,000, it is reset to 1 and no longer increases.).

Is this expected behavior? Because if the ref counting resets to 1 the
fs will break when somebody tries to delete the file. Or is just the
number reported to userspace wrong?

> But EMLINK error value test need the directory have a valid LINK_MAX,
> so for ext4, we use mkfs to clear "dir_index" filesystem feature, then
> ext4 has a LINK_MAX:65000: mkfs.ext4 -O ^dir_index device

So this is the same problem as with XFS.

I still think that correct solution to this problem is to write a
function that detects if there is a limit on number of links given a
filesystem path. Then we can simply skip the EMLINK test if the number
of links is unlimited.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2] syscalls/rename/rename11.c: add ELOOP, EMLINK and EROFS error value tests

[chrubis]

Hi!
> Yeah, it's expected behavior for ext4.
> Please this this url: https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Storage_Administration_Guide/installconfig-fs.html
> 
> Note: here the discussion is for directory.
> 
> I checked the ext4 kernel source code in RHEL7.0RC:
> 
> static void ext4_inc_count(handle_t *handle, struct inode *inode)
> {
>          inc_nlink(inode);
>          if (is_dx(inode) && inode->i_nlink > 1) {
>                  if (inode->i_nlink >= EXT4_LINK_MAX || inode->i_nlink == 2) {
>                          set_nlink(inode, 1);
>                          EXT4_SET_RO_COMPAT_FEATURE(inode->i_sb,
>                                                EXT4_FEATURE_RO_COMPAT_DIR_NLINK);
>                  }
>          }
> }
> 
> Here EXT4_LINK_MAX is 65000. From the above code, we can
> see that if "is_dx(inode)" returns true and i_nlink count is greater than 65000.
> i_nlink will be reset to 1. Then if you stat parent directory, you will see its link_count is 1.
> 
> When we try to rmdir a directory, I also checked the ext4 kernel source code.
> If a directory had nlink == 1, then the ext4 will still let it be 1.
> 
> You can observe this by following steps:
> [root@localhost ~]# mkdir ext4_test/
> [root@localhost ~]# cd ext4_test/; for((i=0; i <=65000;i++)) do mkdir $i; done;
> [root@localhost ext4_test]# stat .
>   File: '.'
>   Size: 1392640         Blocks: 2728       IO Block: 4096   directory
> Device: 801h/2049d      Inode: 3678747     Links: 1
> Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
> Access: 2014-05-20 19:36:24.541944536 +0800
> Modify: 2014-05-20 19:35:59.724942953 +0800
> Change: 2014-05-20 19:35:59.724942953 +0800
>  Birth: -
> 
> Now the links is 1.
> If you delete some directory, the links will still be 1.
> 
> So if we want to have a 65000 limit, we should  "mkfs.ext4 -O ^dir_index device", thanks.

Ok, thanks for the detailed explanation.

> >> But EMLINK error value test need the directory have a valid LINK_MAX,
> >> so for ext4, we use mkfs to clear "dir_index" filesystem feature, then
> >> ext4 has a LINK_MAX:65000: mkfs.ext4 -O ^dir_index device
> > So this is the same problem as with XFS.
> >
> > I still think that correct solution to this problem is to write a
> > function that detects if there is a limit on number of links given a
> > filesystem path. Then we can simply skip the EMLINK test if the number
> > of links is unlimited.
> 
> Agree, thanks.
> For xfs, the number of links is unlimited.
> For ext2/3, the number of links is 32000.
> For ext4, it depends some options.
> 
> So for xfs, I will skip EMLINK test for it.
> For other files ystems, I will try to create as many as files, until the EMLINK Is hit.
> if EMLINK is not hit, there must be some other errors, such as ENOSPC, for this
> case,  the EMLINK test should also be skipped.

What about we create tst_get_max_links(const char *path) library
function that would either return the actual limit or -1 if unlimited?

Because this would be needed in more than one testcase, at least in the
link() and linkat() ones.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 1/2] runltp: fix errors when using getenv(3) to get environment variable LTP_BIG_DEV or LTP_BIG_DEV_FS_TYPE

[chrubis]

Hi!
> Make runltp export LTP_BIG_DEV and LTP_BIG_DEV_FS_TYPE only when they have a non-zero
> value. We do this to make getenv("LTP_BIG_DEV") or getenv("LTP_BIG_DEV_FS_TYPE")
> return NULL, if user does not specify a big block device. Because users usually write
> such code:
> 	device = getenv("LTP_BIG_DEV");
> 	if (device == NULL) {
> 		tst_brkm(TCONF, NULL,
> 			 "you must specify a big blockdevice(>1.2G)");
> 	} else {
> 		tst_mkfs(NULL, device, "ext3", NULL);
> 	}

I've shortened the first line of the commit description a bit and
pushed the patch, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list