[LTP] Fw:Re: [ltp] ltp / testscripts / ltpstress.sh #line 257 : error command format for sar (#10)

[LTP] Fw:Re: [ltp] ltp / testscripts / ltpstress.sh #line 257 : error command format for sar (#10)

[李奎]

[-- Attachment #1.1: Type: text/plain, Size: 467 bytes --]

Hi,   
    Attach the patch file for fix sar command error.


-------- 转发邮件信息 --------
发件人："Cyril Hrubis" <notifications@github.com>
发送日期：2014-04-01 21:23:33
收件人：linux-test-project/ltp <ltp@noreply.github.com>
抄送人：look <eeslook@163.com>
主题：Re: [ltp]  ltp / testscripts / ltpstress.sh #line 257 : error command format for sar  (#10)


Can you please send a patch to the LTP mailing list?

—
Reply to this email directly or view it on GitHub.

[-- Attachment #1.2: Type: text/html, Size: 1219 bytes --]

[-- Attachment #2: ltp-fix-sar-commanderr-20140401.patch --]
[-- Type: application/octet-stream, Size: 445 bytes --]

diff -rupN ltp-20140115/testscripts/ltpstress.sh ltp-20140115-sar/testscripts/ltpstress.sh
--- ltp-20140115/testscripts/ltpstress.sh	2014-01-16 01:26:29.000000000 +0800
+++ ltp-20140115-sar/testscripts/ltpstress.sh	2014-04-01 10:17:16.814820700 +0800
@@ -254,7 +254,7 @@ ${LTPROOT}/bin/rand_lines -g ${LTPROOT}/
 sleep 2
 
 if [ $Sar -eq 1 ]; then
-  sar -o $datafile $interval 0 &
+  sar -o $datafile $interval &
 fi
 
 if [ $Top -eq 1 ]; then

[-- Attachment #3: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Fw:Re: [ltp] ltp / testscripts / ltpstress.sh #line 257 : error command format for sar (#10)

[chrubis]

Hi!
>     Attach the patch file for fix sar command error.
> 
> 
> -------- ???????????? --------
> ????????"Cyril Hrubis" <notifications@github.com>
> ??????????2014-04-01 21:23:33
> ????????linux-test-project/ltp <ltp@noreply.github.com>
> ????????look <eeslook@163.com>
> ??????Re: [ltp]  ltp / testscripts / ltpstress.sh #line 257 : error command format for sar  (#10)
> 
> 
> Can you please send a patch to the LTP mailing list?

Can you also write short commit message (with kernel like Signed-of-by:
line) that explains the change?

I've looked at the systat pages and the looks like zero was never
supported as a number of iterations (but may have been wrongly accepted
some time ago).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Fw:Re: [ltp] ltp / testscripts / ltpstress.sh #line 257 : error command format for sar (#10)

[chrubis]

Hi!
> Hello Cyril Hrubis,

Sorry for the delay, I've been quite bussy with the release.

>     You are right! this error was found at lastest version(20140115).
>     I add 2 patch files:    
>     1. ltp-fix-sar-command-error-20140411.patch:
>         Fix sar command error with commit messages.

This one looks good to me.

>     2.ltp-fix-bad-variable-nameerr-20140411.patch:
>          Fix a bad variable name in runltp script for DEFAULT_FILE_NAME_GENERATION_TIME when ltp running at
>          differenct language os(chinese).
>         This error was found in  my os, I use zh_CN for default language, the `date +"%Y_%b_%d-%Hh_%Mm_%Ss"`
>         will get like "2014_ 4??_11-09h_36m_52s", it can not be a variable name because include chinese characters.

Can you please move this detailed description to the patch itself so
that it gets included in the git repository?

Also please add a signed-of-by line to the patches (git can help create
these once you setup your name and email address) and send these to
mailing list one patch per email (ideally inline as well as attached).

There is a good howto for sumbitting patches to Linux kernel and most of
the information is applicable to other open source projects as well.
Have a look at:

https://www.kernel.org/doc/Documentation/SubmittingPatches

At least paragraphs 2, 3, 7, 11 are directly applicable to LTP as well.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list