From: chrubis@suse.cz
To: look <eeslook@163.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] Fix an bad variable name erro in runltp script
Date: Mon, 5 May 2014 15:51:14 +0200 [thread overview]
Message-ID: <20140505135114.GA10741@rei> (raw)
In-Reply-To: <47b112ce.152ba.145b070f2b0.Coremail.eeslook@163.com>
Hi!
> I got an error for the latest version 20140115 of ltp project.
> This error was found in my os, I use zh_CN for default language,
> the `date +"%Y_%b_%d-%Hh_%Mm_%Ss"` will get like "2014_ 4yue_11-09h_36m_52s",
> it contain a space before "4yue" will get the bad variable name error.
>
>
> I fix this error and change the date args, see detail below:
> - local DEFAULT_FILE_NAME_GENERATION_TIME=`date +"%Y_%b_%d-%Hh_%Mm_%Ss"`
> + local DEFAULT_FILE_NAME_GENERATION_TIME=`date +"%Y_%m_%d-%Hh_%Mm_%Ss"`
I've reworded the summary a bit, added quotes around the variable and
pushed, thanks.
PS: I've been unable to reproduce the bug, for me date +%b does not add
a space before the month even with LC_ALL=zh_CN, but IMHO number is
better than month abbreviation that is different for each language.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for releasing software faster
• Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
parent reply other threads:[~2014-05-05 13:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <47b112ce.152ba.145b070f2b0.Coremail.eeslook@163.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505135114.GA10741@rei \
--to=chrubis@suse.cz \
--cc=eeslook@163.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox