From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 1/2] pwrite/pwrite02.c: cleanup
Date: Mon, 5 May 2014 17:20:27 +0200 [thread overview]
Message-ID: <20140505152026.GA11256@rei> (raw)
In-Reply-To: <1395993726-10999-1-git-send-email-wangxg.fnst@cn.fujitsu.com>
Hi!
> Merge pwrite02, pwrite03 into one pwrite02 test, which contains
> ESPIPE, EINVAL, EBADF and EFAULT tests.
>
> Remove useless comments and make use of SAFE_MACROS().
>
> Delete some useless code and do some code re-arrangement.
>
> printf() is not async-signal-safe, so use write(2) in signal handler directly.
For some strange reason this patch appears to be broken.
I see it's encoding set to y instead of us-ascii or something reasonable
and even when I rewrite that manually it fails to apply.
Can you please send it once again?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for releasing software faster
• Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-05-05 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 8:02 [LTP] [PATCH 1/2] pwrite/pwrite02.c: cleanup Xiaoguang Wang
2014-03-28 8:02 ` [LTP] [PATCH 2/2] pwrite/pwrite02.c: make EBADF error value tests sufficient Xiaoguang Wang
2014-05-05 15:20 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505152026.GA11256@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox