From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WhKht-0002w0-Ty for ltp-list@lists.sourceforge.net; Mon, 05 May 2014 15:21:29 +0000 Date: Mon, 5 May 2014 17:20:27 +0200 From: chrubis@suse.cz Message-ID: <20140505152026.GA11256@rei> References: <1395993726-10999-1-git-send-email-wangxg.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1395993726-10999-1-git-send-email-wangxg.fnst@cn.fujitsu.com> Subject: Re: [LTP] [PATCH 1/2] pwrite/pwrite02.c: cleanup List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Xiaoguang Wang Cc: ltp-list@lists.sourceforge.net Hi! > Merge pwrite02, pwrite03 into one pwrite02 test, which contains > ESPIPE, EINVAL, EBADF and EFAULT tests. > > Remove useless comments and make use of SAFE_MACROS(). > > Delete some useless code and do some code re-arrangement. > > printf() is not async-signal-safe, so use write(2) in signal handler directly. For some strange reason this patch appears to be broken. I see it's encoding set to y instead of us-ascii or something reasonable and even when I rewrite that manually it fails to apply. Can you please send it once again? -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list