From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WjqSt-0003ZS-Aj for ltp-list@lists.sourceforge.net; Mon, 12 May 2014 13:40:23 +0000 Date: Mon, 12 May 2014 15:39:19 +0200 From: chrubis@suse.cz Message-ID: <20140512133919.GD4741@rei> References: <1399468619-27317-1-git-send-email-alexey.kodanev@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1399468619-27317-1-git-send-email-alexey.kodanev@oracle.com> Subject: Re: [LTP] [PATCH] device-drivers/acpi/ltp_acpi_cpufreq: fix checking for write permission List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Alexey Kodanev Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net Hi! > If access(some_file, W_OK) is executed by root it will return success even > if the file has read-only permission. Use 'open' to test sysfs file for write > permission. This may be worth of a paragraph in Common Problems section in Test-Writing-Guidelines. The patch itself is OK. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list