Re: [LTP] [PATCH 2/2] readahead02: read in 2M chunks

[chrubis@suse.cz]

Hi!
> Max readahead size has been limited since commit:
>   commit 6d2be915e589b58cb11418cbe1f22ff90732b6ac
>   Author: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
>   Date:   Thu Apr 3 14:48:23 2014 -0700
>     mm/readahead.c: fix readahead failure for memoryless NUMA nodes
>                     and limit readahead pages
> 
> Update testcase to read ahead in 2M chunks, this change is
> compatible with older kernels.
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>  testcases/kernel/syscalls/readahead/readahead02.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/readahead/readahead02.c b/testcases/kernel/syscalls/readahead/readahead02.c
> index 8940821..5b1524e 100644
> --- a/testcases/kernel/syscalls/readahead/readahead02.c
> +++ b/testcases/kernel/syscalls/readahead/readahead02.c
> @@ -213,8 +213,13 @@ static void read_testfile(int do_readahead, const char *fname, size_t fsize,
>  		tst_brkm(TBROK | TERRNO, cleanup, "Failed to open %s", fname);
>  
>  	if (do_readahead) {
> -		TEST(ltp_syscall(__NR_readahead, fd, (off64_t) 0,
> -			(size_t) fsize));
> +		/* read ahead in chunks, 2MB is maximum since 3.15-rc1 */
> +		for (i = 0; i < fsize; i += 2*1024*1024) {
> +			TEST(ltp_syscall(__NR_readahead, fd,
> +				(off64_t) i, 2*1024*1024));
> +			if (TEST_RETURN != 0)
> +				break;
> +		}

These two patches looks good to me.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list