From: chrubis@suse.cz
To: "gux.fnst@cn.fujitsu.com" <gux.fnst@cn.fujitsu.com>
Cc: "ltp-list@lists.sourceforge.net" <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 1/2] rmdir/rmdir02.c: cleanup
Date: Thu, 15 May 2014 14:12:00 +0200 [thread overview]
Message-ID: <20140515121200.GB23965@rei.Home> (raw)
In-Reply-To: <1397731818-26430-1-git-send-email-gux.fnst@cn.fujitsu.com>
Hi!
> + memset(longpathname, 'a', PATH_MAX + 2);
I've changed this to:
memset(longpathname, 'a', PATH_MAX + 1);
So that longpathname is zero terminated sting.
> - /* resume original working directory */
> - chdir(cwd);
> + SAFE_TOUCH(cleanup, TESTFILE2, FILE_MODE, NULL);
>
> - return (strlen(longpath) >= PATH_MAX) ? 0 : -1;
> +#if !defined(UCLINUX)
> + test_cases[4].dir = SAFE_MMAP(cleanup, 0, 1, PROT_NONE,
> + MAP_PRIVATE_EXCEPT_UCLINUX | MAP_ANONYMOUS, 0, 0);
> +#endif
And changed the MAP_PRIVATE_EXCEPT_UCLINUX to just MAP_PRIVATE, because
it's in #if !defined(UCLINUX) block anyway.
And pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-05-15 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 10:50 [LTP] [PATCH 1/2] rmdir/rmdir02.c: cleanup gux.fnst
2014-04-17 10:50 ` [LTP] [PATCH 2/2] rmdir/rmdir02.c: add ELOOP, EROFS and EBUSY error value tests gux.fnst
2014-05-15 12:14 ` chrubis
[not found] ` <53756E7A.6070009@cn.fujitsu.com>
2014-05-19 12:15 ` chrubis
2014-05-15 12:12 ` chrubis [this message]
2014-05-15 12:15 ` [LTP] [PATCH 1/2] rmdir/rmdir02.c: cleanup chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515121200.GB23965@rei.Home \
--to=chrubis@suse.cz \
--cc=gux.fnst@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox