From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WmMmU-0001dA-Et for ltp-list@lists.sourceforge.net; Mon, 19 May 2014 12:35:02 +0000 Date: Mon, 19 May 2014 14:34:50 +0200 From: chrubis@suse.cz Message-ID: <20140519123450.GA4331@rei> References: <1400147025-17705-1-git-send-email-wangxg.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1400147025-17705-1-git-send-email-wangxg.fnst@cn.fujitsu.com> Subject: Re: [LTP] [PATCH RFC v2] change MAKE_TARGETS's dependency to normal prerequisites and order-only prerequisites List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Xiaoguang Wang Cc: ltp-list@lists.sourceforge.net Hi! > -MAKE_DEPS := $(LIBLTP) $(LSN_H) > +MAKE_ORDER_ONLY_DEPS := $(LSN_H) > +MAKE_NORMAL_DEPS := $(LIBLTP) Looking at this, the LSN_H is linux_syscall_numbers.h header, shouldn't we recompile a testcases if this header changes as well? Can't we just change the MAKE_DEPS to normal dependencies and be done with it? Anyway we should check twice that this would not break recepies with automatic list of prerequisities $^ which does not include order only ones. -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list