[LTP] [PATCH] lstat/lstat03.c: Fix broken file type check

[LTP] [PATCH] lstat/lstat03.c: Fix broken file type check

[Nicolas Joly]

Signed-off-by: Nicolas Joly <njoly@pasteur.fr>
---
 testcases/kernel/syscalls/lstat/lstat03.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/lstat/lstat03.c b/testcases/kernel/syscalls/lstat/lstat03.c
index d48d1ab..2d8716c 100644
--- a/testcases/kernel/syscalls/lstat/lstat03.c
+++ b/testcases/kernel/syscalls/lstat/lstat03.c
@@ -131,7 +131,7 @@ int main(int ac, char **av)
 		 */
 		if ((stat_buf.st_uid != user_id) ||
 		    (stat_buf.st_gid != group_id) ||
-		    (!(stat_buf.st_mode && S_IFLNK)) ||
+		    (!(stat_buf.st_mode & S_IFLNK)) ||
 		    (stat_buf.st_size != strlen(TESTFILE))) {
 			tst_resm(TFAIL, "Functionality of lstat(2) on "
 				 "'%s' Failed", SFILE);
-- 
1.9.0


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their 
applications. Written by three acclaimed leaders in the field, 
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] lstat/lstat03.c: Fix broken file type check

[chrubis]

Hi!
> Signed-off-by: Nicolas Joly <njoly@pasteur.fr>
> ---
>  testcases/kernel/syscalls/lstat/lstat03.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/lstat/lstat03.c b/testcases/kernel/syscalls/lstat/lstat03.c
> index d48d1ab..2d8716c 100644
> --- a/testcases/kernel/syscalls/lstat/lstat03.c
> +++ b/testcases/kernel/syscalls/lstat/lstat03.c
> @@ -131,7 +131,7 @@ int main(int ac, char **av)
>  		 */
>  		if ((stat_buf.st_uid != user_id) ||
>  		    (stat_buf.st_gid != group_id) ||
> -		    (!(stat_buf.st_mode && S_IFLNK)) ||
> +		    (!(stat_buf.st_mode & S_IFLNK)) ||

Good catch, although this is not yet correct. The file types are not
bitflags so the correct way here is:

	((stat_buf.st_mode & S_IFMT) != S_IFLNK)

I've corrected the patch and pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their 
applications. Written by three acclaimed leaders in the field, 
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list