From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2 2/2] linkat/linkat02.c: cleanup
Date: Mon, 16 Jun 2014 16:47:06 +0200 [thread overview]
Message-ID: <20140616144706.GA23728@rei.suse.cz> (raw)
In-Reply-To: <1402299431-2045-2-git-send-email-wangxg.fnst@cn.fujitsu.com>
Hi!
> - while (1) {
> - sprintf(lname, "%s%ld", BASENAME, ++link_max);
> - TEST(link(TEST_EMLINK, lname));
> - if (TEST_RETURN == -1) {
> - switch (TEST_ERRNO) {
> - case EMLINK:
> - tst_resm(TINFO, "for %s the max links is %ld",
> - fstype, link_max);
> - break;
> - default:
> - tst_brkm(TBROK | TTERRNO, cleanup,
> - "Unexpected error: ");
> - break;
> - }
> - break;
> - }
> - }
> -}
You have removed the code that initializes lname which broke the test
because empty string was passed to the link() call. I've fixed it and
pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-06-16 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 7:37 [LTP] [PATCH v2 1/2] lib: add tst_fs_link_count.c Xiaoguang Wang
2014-06-09 7:37 ` [LTP] [PATCH v2 2/2] linkat/linkat02.c: cleanup Xiaoguang Wang
2014-06-16 14:47 ` chrubis [this message]
2014-06-12 17:32 ` [LTP] [PATCH v2 1/2] lib: add tst_fs_link_count.c chrubis
[not found] ` <539A8784.7010709@cn.fujitsu.com>
2014-06-16 14:05 ` chrubis
[not found] ` <539F9939.5000505@cn.fujitsu.com>
2014-06-17 7:53 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616144706.GA23728@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox