From: chrubis@suse.cz
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2 1/2] lib: add tst_fs_link_count.c
Date: Tue, 17 Jun 2014 09:53:27 +0200 [thread overview]
Message-ID: <20140617075327.GA28518@rei.Home> (raw)
In-Reply-To: <539F9939.5000505@cn.fujitsu.com>
Hi!
> > Ok, I will push (slightly modified version).
> >
> > I did a few small changes:
> >
> > * it creates the directory automatically if it does not exist
> >
> > * uses tst_resm() instead of printf()
> >
> > * changed the file/directory numbering to start from 0
> > which simplifies the code a bit
> >
> > * added two simple tests under lib/tests/
>
> Thanks very much for your modification.
> It really looks better than my v2 version, especially for the new comments
> in include/test.h, it is more neater, thanks.
We should also add documentation into the Test Writing Guidelines. Will
you send a patch or should I do it?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-06-17 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 7:37 [LTP] [PATCH v2 1/2] lib: add tst_fs_link_count.c Xiaoguang Wang
2014-06-09 7:37 ` [LTP] [PATCH v2 2/2] linkat/linkat02.c: cleanup Xiaoguang Wang
2014-06-16 14:47 ` chrubis
2014-06-12 17:32 ` [LTP] [PATCH v2 1/2] lib: add tst_fs_link_count.c chrubis
[not found] ` <539A8784.7010709@cn.fujitsu.com>
2014-06-16 14:05 ` chrubis
[not found] ` <539F9939.5000505@cn.fujitsu.com>
2014-06-17 7:53 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617075327.GA28518@rei.Home \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox