Re: [LTP] [PATCH 2/3] utimes/utimes01.c: cleanup

[chrubis@suse.cz]

Hi!
> -/* History:     Porting from Crackerjack to LTP is done by		    */
> -/*	      Manas Kumar Nayak maknayak@in.ibm.com>			*/

I've added this to the header under the Authors.

> -		/**
> -		 * Note (garrcoop):
> -		 *
> -		 * If you do NULL directly, then gcc [4.3] will complain when
> -		 * one specifies -Wnonnull in CPPFLAGS. This is a negative
> -		 * test, but let's not allow the compiler to complain about
> -		 * something trivial like this.
> -		 **/
> -		const char *dummy = NULL;
> -		TEST(sys_ret = utimes(dummy, tv));
> +	if (TEST_ERRNO == tc->exp_errno) {
> +		tst_resm(TPASS | TTERRNO, "utimes() failed as expected");
                                                      ^
				      I've changed this to "worked as expected"
				      because the first two testcases
				      do not fait at all.

Also I may be better to split the test into two files one for positive
tests and one for negative tests because as it is the code does not
check that utimes() actually changed the times and we may add test that
calls utimes() with NULL times, which should set the times to current
time. Adding these changes to the currect code would overcomplicate the
verify function...

Patchset applied, Thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list