public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 1/3] syscalls: fix returning TCONF without device
Date: Wed, 18 Jun 2014 17:58:19 +0200	[thread overview]
Message-ID: <20140618155819.GC4466@rei> (raw)
In-Reply-To: <20140617111120.GA31854@rei>

Hi!
> I was thinking of adding a function that would either get the LTP_DEV
> env variable or create a loop0 device if LTP_DEV is not set and will
> format it with LTP_DEV_FS_TYPE or a default passed value and it's
> counter part that does the cleanup.

I've pushed the function implementation + documentation in
test-writing-guidelines. Have a look if you are interested.

It turned out to be a bit more challenging than I expected because the
loop ioctls() and are poorly documented...

The next step would rewriting all testcases that gets the device as
parameters to use the new interface. I will have a look at these
tomorrow.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2014-06-18 15:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  1:58 [LTP] [PATCH 1/3] syscalls: fix returning TCONF without device Zeng Linggang
2014-06-13  1:59 ` [LTP] [PATCH 2/3] utime/utime06.c: cleanup Zeng Linggang
2014-06-13  2:01 ` [LTP] [PATCH 3/3] utime/utime06.c: add EPERM and EROFS errno testes Zeng Linggang
2014-06-13 11:56 ` [LTP] [PATCH 1/3] syscalls: fix returning TCONF without device Jan Stancek
     [not found]   ` <1402972112.2294.26.camel@G08JYZSD130126>
2014-06-17 11:11     ` chrubis
2014-06-18 15:58       ` chrubis [this message]
     [not found]         ` <1403144011.10350.8.camel@G08JYZSD130126>
     [not found]           ` <1403144473.10350.12.camel@G08JYZSD130126>
2014-06-24 13:06             ` [LTP] [PATCH v2 2/2] utime/utime06.c: add EPERM and EROFS errno testes chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140618155819.GC4466@rei \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=zenglg.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox