public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2 2/2] utime/utime06.c: add EPERM and EROFS errno testes
Date: Tue, 24 Jun 2014 15:06:04 +0200	[thread overview]
Message-ID: <20140624130604.GA7391@rei> (raw)
In-Reply-To: <1403144473.10350.12.camel@G08JYZSD130126>

Hi!
> +	dev = tst_acquire_device(cleanup);
> +	if (!dev)
> +		tst_brkm(TCONF, cleanup, "Failed to acquire test device");
>  
> -	SAFE_SETEUID(cleanup, ltpuser->pw_uid);
> +	tst_mkfs(cleanup, dev, "ext2", NULL);
> +
> +	SAFE_MKDIR(cleanup, MNT_POINT, 0644);
> +	if (mount(dev, MNT_POINT, "ext2", MS_RDONLY, NULL) < 0) {
> +		tst_brkm(TBROK | TERRNO, cleanup,
> +			 "mount device:%s failed", dev);
> +	}
> +	mount_flag = 1;
> +
> +	ltpuser = SAFE_GETPWNAM(cleanup, "nobody");
>  }

I've changed this part to use the tst_dev_fs_type() function to
determine the filesystem type (that I've added for this purpose) and
pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      parent reply	other threads:[~2014-06-24 13:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  1:58 [LTP] [PATCH 1/3] syscalls: fix returning TCONF without device Zeng Linggang
2014-06-13  1:59 ` [LTP] [PATCH 2/3] utime/utime06.c: cleanup Zeng Linggang
2014-06-13  2:01 ` [LTP] [PATCH 3/3] utime/utime06.c: add EPERM and EROFS errno testes Zeng Linggang
2014-06-13 11:56 ` [LTP] [PATCH 1/3] syscalls: fix returning TCONF without device Jan Stancek
     [not found]   ` <1402972112.2294.26.camel@G08JYZSD130126>
2014-06-17 11:11     ` chrubis
2014-06-18 15:58       ` chrubis
     [not found]         ` <1403144011.10350.8.camel@G08JYZSD130126>
     [not found]           ` <1403144473.10350.12.camel@G08JYZSD130126>
2014-06-24 13:06             ` chrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140624130604.GA7391@rei \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=zenglg.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox