From: chrubis@suse.cz
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2 2/3] can: cleanup
Date: Tue, 15 Jul 2014 16:57:55 +0200 [thread overview]
Message-ID: <20140715145754.GA8827@rei> (raw)
In-Reply-To: <1403840536.2119.24.camel@G08JYZSD130126>
Hi!
> When I use <kernel_path>/scripts/checkpatch.pl to check the patch, it
> output like:
> #20: FILE: testcases/network/can/filter-tests/tst-filter.c:84:
> + return (CAN_EFF_MASK | CAN_EFF_FLAG | CAN_RTR_FLAG);
This misses the important part which says:
ERROR: return is not a function, parentheses are not required
so the script is telling you to do:
reutrn CAN_EFF_MASK | CAN_EFF_FLAG | CAN_RTR_FLAG;
instead ;).
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-07-15 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 5:04 [LTP] [PATCH] can: add can tests to default Zeng Linggang
2014-06-12 13:10 ` chrubis
[not found] ` <1403179593.7741.2.camel@G08JYZSD130126>
2014-06-25 15:39 ` [LTP] [PATCH v2 2/3] can: cleanup chrubis
[not found] ` <1403866408.2119.28.camel@G08JYZSD130126>
2014-07-15 14:39 ` [LTP] [PATCH v3 1/3] Add autoconf test for CAN chrubis
[not found] ` <1405932572.5156.7.camel@G08JYZSD130126>
[not found] ` <1405934632.5156.13.camel@G08JYZSD130126>
2014-07-22 14:08 ` [LTP] [PATCH v4 3/3] Make can testes' name more saner chrubis
[not found] ` <1403840536.2119.24.camel@G08JYZSD130126>
2014-07-15 14:57 ` chrubis [this message]
[not found] ` <1403179709.11671.0.camel@G08JYZSD130126>
2014-06-25 15:43 ` [LTP] [PATCH v2 3/3] can: change the entry chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715145754.GA8827@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=zenglg.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox