From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1X74BU-0003dp-Vu for ltp-list@lists.sourceforge.net; Tue, 15 Jul 2014 14:58:25 +0000 Date: Tue, 15 Jul 2014 16:57:55 +0200 From: chrubis@suse.cz Message-ID: <20140715145754.GA8827@rei> References: <1401685455.2838.8.camel@G08JYZSD130126> <20140612131041.GB20221@rei> <1403179593.7741.2.camel@G08JYZSD130126> <20140625153950.GA5552@rei> <1403840536.2119.24.camel@G08JYZSD130126> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1403840536.2119.24.camel@G08JYZSD130126> Subject: Re: [LTP] [PATCH v2 2/3] can: cleanup List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Zeng Linggang Cc: ltp-list Hi! > When I use /scripts/checkpatch.pl to check the patch, it > output like: > #20: FILE: testcases/network/can/filter-tests/tst-filter.c:84: > + return (CAN_EFF_MASK | CAN_EFF_FLAG | CAN_RTR_FLAG); This misses the important part which says: ERROR: return is not a function, parentheses are not required so the script is telling you to do: reutrn CAN_EFF_MASK | CAN_EFF_FLAG | CAN_RTR_FLAG; instead ;). -- Cyril Hrubis chrubis@suse.cz ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list