Re: [LTP] open12 failing on i386 with EOVERFLOW

[chrubis@suse.cz]

Hi!
> # env PATH=`pwd`:$PATH ./open12
> open12      1  TFAIL  :  open12.c:104: test O_APPEND for open failed
> open12      2  TCONF  :  open12.c:123: test O_NOATIME flag for open needs filesystems which is mounted without noatime and relatime
> open12      3  TPASS  :  test O_CLOEXEC for open success
> open12      4  TPASS  :  test O_LARGEFILE for open success
> open12      0  TWARN  :  tst_tmpdir.c:206: tst_rmdir: rmobj(/tmp/opexIqjV3) failed: lstat(/tmp/opexIqjV3/large_file) failed; errno=75: Value too large for defined data type
> 
> Since it's linked from library, adding -D_FILE_OFFSET_BITS=64 to this testcase has
> no effect.
> 
> One simple way to fix it would be to unlink it in test, so that
> rmobj.c doesn't hit it.

That is simple enough but I'm a bit reluctant to add the fix to each
test that will test O_LARGEFILE.

Given that the only purpose of lstat() in rmobj() is to figure out if
given path is a file or directory, we can try to work around this by
trying to opendir() the path first and treat it like a file when we get
ENOTDIR. What do you think?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list