From: chrubis@suse.cz
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH/RFC] profil01: don't use address of function
Date: Wed, 20 Aug 2014 16:32:52 +0200 [thread overview]
Message-ID: <20140820143252.GA23782@rei> (raw)
In-Reply-To: <d00e2fbc8b2b96403e841845b3df25104dada721.1408543124.git.jstancek@redhat.com>
Hi!
> This testcase is failing on ppc64 BE system, because
> address of &test_profil does not reference beginning of code,
> but entry in .opd section:
> "This section contains the official procedure descriptors.
> A pointer to a function shall reference a procedure descriptor
> in this section."
> which was at address larger than all .text of test_profil.
>
> This patch is replacing address of function approach with gcc's
> __builtin_return_address() to get current pc value.
How is it with compatibility? In which gcc version was this building
introduced? Does it work with clang?
If we are in doubt, we should add a configure check and use it only when
available. And probably to default to &test_profil in all cases but
ppc64 BE which is known to fail.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-08-20 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 14:00 [LTP] [PATCH/RFC] profil01: don't use address of function Jan Stancek
2014-08-20 14:32 ` chrubis [this message]
[not found] ` <290231308.10805374.1408632310290.JavaMail.zimbra@redhat.com>
2014-08-26 8:55 ` chrubis
[not found] ` <1624956800.12985322.1409044708265.JavaMail.zimbra@redhat.com>
2014-08-26 9:22 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820143252.GA23782@rei \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox