Re: [LTP] sendfile06_64 failure on i386

[chrubis@suse.cz]

Hi!
> this testcase is currently failing on i386:
> 
> sendfile06_64    1  TFAIL  :  sendfile06.c:90: sendfile(2) failed to return expected value, expected: 17592186044442, got: 26
> 
> It's using SAFE_FSTAT from libltp, which is not compiled with 
>   -D_FILE_OFFSET_BITS=64 -DOFF_T=__off64_t as the testcase.
> 
> The testcase can pass if I turn SAFE_FSTAT into plain fstat:
> 
> -       SAFE_FSTAT(cleanup, fd, &sb);
> +       TEST(fstat(fd, &sb));
> +       if (TEST_RETURN != 0)
> +               tst_brkm(TBROK | TTERRNO, cleanup, "fstat");
> 
> but I'm wondering if we can fix this at global level, so users
> of safe_macros don't have to worry about this.

I guess that turning the safe_fstat() into static inline function and
putting it into the safe_macros.h header should fix the issue. That way
the fstat would use struct stat64 corectly if corresponding macros are
defined.

Anything else would need more ifdefs and would be fairly tricky to
maintain.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list