From: chrubis@suse.cz
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] safe_macros: turn functions with off_t parameter into static inline
Date: Thu, 21 Aug 2014 13:51:43 +0200 [thread overview]
Message-ID: <20140821115143.GA16159@rei> (raw)
In-Reply-To: <e70bae8bd74a29e9959cae96900a849254b37c9f.1408615314.git.jstancek@redhat.com>
Hi!
> Some functions used to implement safe macros have parameters
> of type off_t or structures containing off_t fields.
>
> We don't want these to be compiled into libltp, because
> some testcases are compiled with different flags such as:
> -D_FILE_OFFSET_BITS=64 -DOFF_T=__off64_t
> which then creates incompatibility and testcases can fail.
>
> For example sendfile06_64 on i386:
> sendfile06_64 1 TFAIL : sendfile06.c:90: sendfile(2) failed
> to return expected value, expected: 17592186044442, got: 26
Looks good, acked.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-08-21 11:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 10:02 [LTP] [PATCH] safe_macros: turn functions with off_t parameter into static inline Jan Stancek
2014-08-21 11:51 ` chrubis [this message]
2014-08-25 13:09 ` chrubis
[not found] ` <400651514.12451738.1408972658808.JavaMail.zimbra@redhat.com>
2014-08-25 14:07 ` chrubis
[not found] ` <1251340269.12540621.1408977990485.JavaMail.zimbra@redhat.com>
[not found] ` <1139993286.12980615.1409044361683.JavaMail.zimbra@redhat.com>
2014-08-26 9:36 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821115143.GA16159@rei \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox