Re: [LTP] open12 failing on i386 with EOVERFLOW

[chrubis@suse.cz]

Hi!
> > > That is simple enough but I'm a bit reluctant to add the fix to each
> > > test that will test O_LARGEFILE.
> > > 
> > > Given that the only purpose of lstat() in rmobj() is to figure out if
> > > given path is a file or directory, we can try to work around this by
> > > trying to opendir() the path first and treat it like a file when we get
> > > ENOTDIR. What do you think?
> > 
> > I like the idea. I can try it tomorrow, unless you have patch ready.
> 
> I hit some issues with opendir() because it tries to follow symlinks,
> so in case of bad symlink I was getting ENOENT, in some testcases ELOOP.

Doesn't that mean that we are not dealing with a directory and should
proceed with the unlink()? Or am I mistaken?

> I posted version using plain open(O_DIRECTORY | O_NOFOLLOW,..), if you
> want to comment on such approach. Initial results from x86 and ppc64 looked
> good, so I'll run it through some more testing.

This looks good, maybe better than the original idea and given that both
flags were added to kernel 2.1.126 we can just assume that these are
present anywhere.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list