Re: [LTP] [PATCH 2/2] network/stress/broken_ip: move common code to library

[chrubis@suse.cz]

Hi!
> +tst_set_ipv4_addr()
> +{
> +	# Initialize test interfaces
> +	# The number of the test link where tests run
> +	LINK_NUM=${LINK_NUM:-0}
> +
> +	initialize_if lhost ${LINK_NUM}
> +	initialize_if rhost ${LINK_NUM}
> +
> +	# Netmask of the IPv4 network
> +	network_mask=24
> +
> +	tst_resm TINFO "set remote ipv4 addr '$IPV4_NETWORK $RHOST_IPV4_HOST'"
> +	# Set IPv4 addresses to the interfaces
> +	set_ipv4addr rhost $LINK_NUM $IPV4_NETWORK $RHOST_IPV4_HOST
> +	if [ $? -ne 0 ]; then
> +		tst_brkm TBROK "Failed to add any IP address at the remote host"
> +	fi
> +
> +	tst_resm TINFO "set local ipv4 addr '$IPV4_NETWORK $LHOST_IPV4_HOST'"
> +	set_ipv4addr lhost $LINK_NUM $IPV4_NETWORK $LHOST_IPV4_HOST
> +	if [ $? -ne 0 ]; then
> +		tst_brkm TBROK "Failed to add any IP address at the local host"
> +	fi
> +}

I would love to get the code from initialize_if and set_ipv4addr to be
cleaned and moved here to the test_net.sh but that would require
changing all the stress testcases first.

The changes looks good to me, acked.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce.
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list